Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: convert accounts mvp to mvvm architecture #2890

Merged
merged 3 commits into from Oct 13, 2019

Conversation

@codedsun
Copy link
Contributor

codedsun commented Oct 10, 2019

Fixed #2889 : Converted accounts mvp to mvvm architecture

Changes: Removed the presenter, contractor and introduced viewmodel and repository

Screenshots of the change:

@auto-label auto-label bot added the Feature label Oct 10, 2019
@codedsun

This comment has been minimized.

Copy link
Contributor Author

codedsun commented Oct 10, 2019

@iamareebjamal @yashk2000 Please check and merge!

Suneet Srivastava added 2 commits Oct 11, 2019
@codedsun

This comment has been minimized.

Copy link
Contributor Author

codedsun commented Oct 12, 2019

@iamareebjamal Merge this!

@codedsun

This comment has been minimized.

Copy link
Contributor Author

codedsun commented Oct 12, 2019

@iamareebjamal Please merge this

@yashk2000 yashk2000 requested a review from iamareebjamal Oct 13, 2019
@iamareebjamal iamareebjamal merged commit 7c4f5cf into fossasia:development Oct 13, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.