New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor:solved communication issues in CH2 and CH1 #1066

Merged
merged 1 commit into from Jun 17, 2018

Conversation

4 participants
@abhinavraj23
Copy link
Member

abhinavraj23 commented Jun 16, 2018

Fixes #1001

Changes:
Channel CH1 and CH2 are also working now which were completely nonfunctional initially.

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing:
app-debug.apk.zip

@abhinavraj23

This comment has been minimized.

Copy link
Member

abhinavraj23 commented Jun 16, 2018

@CloudyPadmal CloudyPadmal merged commit 551ebd0 into fossasia:development Jun 17, 2018

1 of 2 checks passed

Codacy/PR Quality Review Codacy was unable to analyse your pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@abhinavraj23 abhinavraj23 deleted the abhinavraj23:channel_voltage branch Jun 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment