New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #138 Completes methods of analog section in ScienceLab #141

Merged

viveksb007 merged 1 commit into fossasia:master from asitava1998:master

Jun 2, 2017

Contributor

asitava1998 commented Jun 2, 2017

The flush method is commented on line 1122 as it has not been implemented

asitava1998 requested review from viveksb007, CloudyPadmal and akarshan96

June 2, 2017 09:12

akarshan96 approved these changes

View reviewed changes

CloudyPadmal approved these changes

View reviewed changes


          Fixes #138 Completes methods of analog section in ScienceLab

5986de3

viveksb007 approved these changes

View reviewed changes

Member

viveksb007 left a comment

Some methods would be exposed for functionality, so they should be public. But we can change it as we use them in Application Activities.

viveksb007 merged commit 682d9ae into fossasia:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment