New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #21 : Project files are visible in the project tree #22

Closed
wants to merge 3 commits into
from

Conversation

2 participants
@CloudyPadmal
Contributor

CloudyPadmal commented Jun 2, 2017

Project files were manually added to the configuration.xml to make them visible in the Project Tree.

@CloudyPadmal CloudyPadmal requested a review from jithinbp Jun 2, 2017

@CloudyPadmal CloudyPadmal added enhancement and removed enhancement labels Jun 2, 2017

Show outdated Hide outdated PSLab_Original/PSLAB_UART.c
c1 = getChar()&0xFF;
c2 = getChar()&0xFF;
return (c2 << 8) | c1;
return ((getChar()&0xFF << 8) | (getChar()&0xFF));

This comment has been minimized.

@jithinbp

jithinbp Jun 3, 2017

Contributor

Lines 94 to 96 have been condensed into Line 97 , but it looks like the byte order will be reversed.
In the original case, LSB is received first, followed by MSB . In the new instance, the first BYTE will be treated
as MSB, and the second as LSB . Please confirm the order.

@jithinbp

jithinbp Jun 3, 2017

Contributor

Lines 94 to 96 have been condensed into Line 97 , but it looks like the byte order will be reversed.
In the original case, LSB is received first, followed by MSB . In the new instance, the first BYTE will be treated
as MSB, and the second as LSB . Please confirm the order.

This comment has been minimized.

@CloudyPadmal

CloudyPadmal Jun 3, 2017

Contributor

Yes @jithinbp that would be wrong then! I'll fix it now! Thanks for pointing out!!

@CloudyPadmal

CloudyPadmal Jun 3, 2017

Contributor

Yes @jithinbp that would be wrong then! I'll fix it now! Thanks for pointing out!!

Show outdated Hide outdated PSLab_Original/PSLAB_UART.c
c1 = getChar2()&0xFF;
c2 = getChar2()&0xFF;
return (c2 << 8) | c1;
return ((getChar2()&0xFF << 8) | (getChar2()&0xFF));

This comment has been minimized.

@jithinbp

jithinbp Jun 3, 2017

Contributor

please refer to the previous comment on line 96 , function unsigned int getInt

@jithinbp

jithinbp Jun 3, 2017

Contributor

please refer to the previous comment on line 96 , function unsigned int getInt

This comment has been minimized.

@CloudyPadmal

CloudyPadmal Jun 3, 2017

Contributor

Thank you @jithinbp ! I've fixed it and sent a fix now!

@CloudyPadmal

CloudyPadmal Jun 3, 2017

Contributor

Thank you @jithinbp ! I've fixed it and sent a fix now!

@jithinbp

I have added inline comments for PSLAB_UART.c . there appears to be a critical bug

based on https://github.com/github/gitignore/blob/master/Global/NetBeans.gitignore , private files specific to the IDE can be added to the gitignore. You may also have to manually untrack the ones already added.

proto2_main.c looks good. There seem to be quite a few changes pertaining to Codacy specifications, and I hope I did not miss any alterations to algorithms anywhere.
thanks.

Update functions.h
Duplicate entries of c1 and c2 removed
@CloudyPadmal

This comment has been minimized.

Show comment
Hide comment
@CloudyPadmal

CloudyPadmal Jun 3, 2017

Contributor

@jithinbp I've added PSLab_Original/nbproject/private to the .gitignore file! 👍

Contributor

CloudyPadmal commented Jun 3, 2017

@jithinbp I've added PSLab_Original/nbproject/private to the .gitignore file! 👍

@CloudyPadmal

This comment has been minimized.

Show comment
Hide comment
@CloudyPadmal

CloudyPadmal Jun 3, 2017

Contributor

Changes were merged when #23 was merged. Hence closing this.

Contributor

CloudyPadmal commented Jun 3, 2017

Changes were merged when #23 was merged. Hence closing this.

@CloudyPadmal CloudyPadmal deleted the CloudyPadmal:ProjectTree_Fix branch Jun 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment