Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin: Improve Bots page, add columns #2794

Merged
merged 6 commits into from Aug 23, 2019

Conversation

harsh-jindal
Copy link
Member

@harsh-jindal harsh-jindal commented Aug 6, 2019

Fixes #2873

Changes: Added Defualt Skills and Bot Sites column.

Demo Link: https://pr-2794-fossasia-susi-web-chat.surge.sh

Screenshots of the change: [Add screenshots depicting the changes.]
Screenshot 2019-08-06 at 6 52 54 PM

@harsh-jindal
Copy link
Member Author

Drafts tab shall be added after this is merged fossasia/susi_server#1362

@harsh-jindal
Copy link
Member Author

Draft API not fetching all the drafts. Opened an issue for the same here: fossasia/susi_server#1364

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Under Actions "View" only shows the page with the draft name, but no other bots info. It only shows the standard info.
    Screenshot from 2019-08-08 07-59-06
  • Author of bot is missing

@harsh-jindal
Copy link
Member Author

@mariobehling Getting the author name and showing the info on clicking on view option depends on getting the emailID from the server but while storing a new bot we only store the uuid of the user. I had asked on the gitter channel if there is some way to get emailId from uuid here: https://gitter.im/fossasia/susi_server?at=5d48329041d5cd61b5bade43

Copy link
Member

@akshatnitd akshatnitd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Research on how it can be done, rather than waiting to someone to do it for you. I am sure, this is being used somewhere in the codebase. Search the codebase properly.

@harsh-jindal
Copy link
Member Author

@akshatnitd I have researched on it. Uuid is formed from encoding the user's email. It's a one way encoding. So IMO we shall save the users email while creating a new bot. But then for old bots the view and modify will not work.
Please suggest other ways. Maybe I can try looping through all the authorized clients and check whether they have bots and display. Shall I go ahead this way ?

Copy link
Member

@akshatnitd akshatnitd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a separate issue for the missing field and finalise this PR.

@harsh-jindal
Copy link
Member Author

@akshatnitd Made the changes. Please review.
Note: Only additions of columns is done in this PR.
View option needs to fixed on the server as said in previous comments we need email Id from uuid for that.

@mariobehling mariobehling merged commit 4699287 into fossasia:master Aug 23, 2019
pulkit1joshi pushed a commit to pulkit1joshi/susi.ai that referenced this pull request Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing columns in Bots Page
5 participants