New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin: Improve Bots page, add columns #2794
Conversation
Drafts tab shall be added after this is merged fossasia/susi_server#1362 |
Draft API not fetching all the drafts. Opened an issue for the same here: fossasia/susi_server#1364 |
3dcb016
to
75caa35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mariobehling Getting the author name and showing the info on clicking on view option depends on getting the emailID from the server but while storing a new bot we only store the uuid of the user. I had asked on the gitter channel if there is some way to get emailId from uuid here: https://gitter.im/fossasia/susi_server?at=5d48329041d5cd61b5bade43 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Research on how it can be done, rather than waiting to someone to do it for you. I am sure, this is being used somewhere in the codebase. Search the codebase properly.
@akshatnitd I have researched on it. Uuid is formed from encoding the user's email. It's a one way encoding. So IMO we shall save the users email while creating a new bot. But then for old bots the view and modify will not work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create a separate issue for the missing field and finalise this PR.
0b8d5d0
to
82745e2
Compare
@akshatnitd Made the changes. Please review. |
Fixes #2873
Changes: Added
Defualt Skills
andBot Sites
column.Demo Link: https://pr-2794-fossasia-susi-web-chat.surge.sh
Screenshots of the change: [Add screenshots depicting the changes.]