Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make API to return a public skill's image #1031

Closed
hkedia321 opened this issue Jul 20, 2018 · 2 comments
Closed

Make API to return a public skill's image #1031

hkedia321 opened this issue Jul 20, 2018 · 2 comments
Labels
feature

Comments

@hkedia321
Copy link
Member

Actual Behaviour

No API present to return the skill's image. Currently, the clients are fetching the images from github directly.

Expected Behaviour

Make an API which extracts the skill's image from susi_skill_data folder locally and send it.

Would you like to work on the issue?

Yes
@Orbiter
Copy link
Contributor

Orbiter commented Jul 21, 2018

Please send the image as actual image, not using base64 encoding.

@hkedia321 hkedia321 mentioned this issue Jul 21, 2018
Merged
@hkedia321
Copy link
Member Author

@Orbiter Yes, I have made changes in the /cms/getImage.png API so that it can be used for three use cases, depending on the parameters provided by the client:

  • getting image for public skills
  • getting image for private skills
  • gettings image from local storage

Please review #1036 and let me know if any changes are needed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Orbiter @hkedia321