Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Reported Skills' servlet for Admin section #1268 #1274

Merged
merged 5 commits into from Jun 18, 2019

Conversation

@fragm3
Copy link
Contributor

commented Jun 13, 2019

Fixes #1268

Changes: Add 'Reported Skills' servlet for Admin section fossasia/susi.ai#2187, Added search functionality for reported skills

@fragm3

This comment has been minimized.

Copy link
Contributor Author

commented Jun 13, 2019

@akshatnitd @Orbiter please review.

@akshatnitd
Copy link
Member

left a comment


if (reportedSkills.has(model_name)) {
JSONObject modelName = reportedSkills.getJSONObject(model_name);
System.out.println("modelName " + modelName);

This comment has been minimized.

Copy link
@akshatnitd

akshatnitd Jun 13, 2019

Member

Remove this.

@@ -0,0 +1,92 @@
package ai.susi.server.api.cms;

This comment has been minimized.

Copy link
@akshatnitd

akshatnitd Jun 13, 2019

Member

The API should in cms folder.

@fragm3 fragm3 force-pushed the fragm3:getreportSkillService branch from cdec91b to 8ed2596 Jun 15, 2019

@fragm3

This comment has been minimized.

Copy link
Contributor Author

commented Jun 15, 2019

@akshatnitd made the changes.
Response:

{
  "session": {"identity": {
    "type": "host",
    "name": "0:0:0:0:0:0:0:1_d9aaded8",
    "anonymous": true
  }},
  "accepted": true,
  "list": [
    {
      "feedback": "test",
      "skill_name": "GSOC",
      "email": "shubhamsuperpro@gmail.com",
      "timestamp": "2019-06-15 03:25:29.425"
    },
    {
      "feedback": "test101",
      "skill_name": "GSOC",
      "email": "shubham@gmail.com",
      "timestamp": "2019-06-15 12:18:33.641"
    }
  ],
  "message": "Success: Fetched all Reported Skills"
}

@fragm3 fragm3 force-pushed the fragm3:getreportSkillService branch from 1906900 to d05e406 Jun 15, 2019

Orbiter and others added some commits Jun 15, 2019

@fragm3

This comment has been minimized.

Copy link
Contributor Author

commented Jun 17, 2019

@akshatnitd, please review

@akshatnitd akshatnitd merged commit dc8530b into fossasia:development Jun 18, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.