Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SkillSlideshow Servlet #1293 #1294

Merged
merged 1 commit into from Jul 9, 2019

Conversation

@fragm3
Copy link
Contributor

commented Jul 7, 2019

Fixes #1293

Changes: The slider images are currently hardcoded into the frontend. Implement services for saving and fetching slider data from the backend

Needed for PR: fossasia/susi.ai#2455

For fetching slider image: http://localhost:4000/cms/getImage.png?sliderImage=Android-Slider.jpg

@fragm3 fragm3 force-pushed the fragm3:skills-slideshow-servlet branch from 9fa4ad5 to cea87a4 Jul 7, 2019

@fragm3 fragm3 changed the title [WIP] Implement SkillSlideshow Servlet #1293 Implement SkillSlideshow Servlet #1293 Jul 7, 2019

@fragm3

This comment has been minimized.

Copy link
Contributor Author

commented Jul 7, 2019

@akshatnitd @Orbiter please review

@fragm3 fragm3 force-pushed the fragm3:skills-slideshow-servlet branch 2 times, most recently from 3943468 to 6e2f950 Jul 7, 2019

@akshatnitd
Copy link
Member

left a comment

All key to store, redirect link to each image well.


/**
* This Servlet gives a API Endpoint to add, modify and delete different API
* keys used by SUSI. It requires user role to be ADMIN or above ADMIN example:

This comment has been minimized.

Copy link
@akshatnitd

akshatnitd Jul 8, 2019

Member

Change it.

throw new APIException(400, "Bad Request. No enough parameter present");
}

String pathname = call.get("pathname", null);

This comment has been minimized.

Copy link
@akshatnitd

akshatnitd Jul 8, 2019

Member

Pathname should not be entered by user.

This comment has been minimized.

Copy link
@fragm3

fragm3 Jul 8, 2019

Author Contributor

Pathname is redirect link, which rename it to redirect_link, to avoid confusion

@fragm3 fragm3 force-pushed the fragm3:skills-slideshow-servlet branch from 6e2f950 to 3981cc4 Jul 8, 2019

@fragm3

This comment has been minimized.

Copy link
Contributor Author

commented Jul 8, 2019

@akshatnitd made the changes, please review again

@akshatnitd
Copy link
Member

left a comment

Why not use the current upload functionality for slideshow images as well?

@fragm3 fragm3 force-pushed the fragm3:skills-slideshow-servlet branch 2 times, most recently from d2245d9 to f424d42 Jul 9, 2019

@fragm3 fragm3 force-pushed the fragm3:skills-slideshow-servlet branch from db19eae to 832e11f Jul 9, 2019

@fragm3

This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2019

@akshatnitd made the changes.

@akshatnitd akshatnitd merged commit 0f7cc7e into fossasia:development Jul 9, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.