Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #586: Add initial version of skill usage card component [WIP] #590

Merged
merged 2 commits into from Jun 8, 2018

Conversation

@anshumanv
Copy link
Member

commented Jun 5, 2018

Fixes #586

Changes: Added an initial version of SkillUsage card component.

Surge Deployment Link: https://pr-590-fossasia-susi-skill-cms.surge.sh

NOTE: Requires fossasia/susi_server#793 to be merged first

Screenshots for the change:
image

@anshumanv anshumanv force-pushed the anshumanv:586 branch from 2500735 to 16e7792 Jun 5, 2018

@anshumanv

This comment has been minimized.

Copy link
Member Author

commented Jun 5, 2018

NOTE: The graph should ideally consume data returned from the API which is yet to be merged, till then it is functioning on sample data and will need some changes after the API is up and running which I'll do ASAP.

self.saveSkillUsage(data.skill_usage)
},
error: function(e) {
self.saveSkillUsage()

This comment has been minimized.

Copy link
@anshumanv

anshumanv Jun 5, 2018

Author Member

This will be updated once the API is functional.

this.setState({
skill_ratings: ratings_data,
avg_rating: parseInt(skill_ratings.avg_star, 10),
total_star: parseInt(skill_ratings.total_star, 10)
})
}

saveSkillUsage = (skill_usage = []) => {
// Add sample data to test
const data = [

This comment has been minimized.

Copy link
@anshumanv

anshumanv Jun 5, 2018

Author Member

This sample data will be deleted once the API returns data.

@anshumanv

This comment has been minimized.

Copy link
Member Author

commented Jun 5, 2018

@akshatnitd @AnupKumarPanwar @Akshat-Jain @DNS-404 @PrP-11 @hkedia321 please review.
Will squash commits after incorporating any needful chanages. 👍

@anshumanv anshumanv changed the title Fixes #586: Add initial version of skill usage card component Fixes #586: Add initial version of skill usage card component [WIP] Jun 5, 2018

@Akshat-Jain
Copy link
Member

left a comment

I'll approve once this is updated with the data being fetched from the server. Looks good with sample data though. Thanks :-)

@AnupKumarPanwar
Copy link
Member

left a comment

LGTM. I've modified the CMS with actual APIs. Once this PR and the server PR is merged. I'll send that PR too.

@PrP-11

PrP-11 approved these changes Jun 5, 2018

Copy link
Member

left a comment

Nice Work!

@akshatnitd
Copy link
Member

left a comment

Looks good for the 1st iteration :)

@DNS-404

DNS-404 approved these changes Jun 6, 2018

@mariobehling

This comment has been minimized.

Copy link
Member

commented Jun 8, 2018

@anshumanv Seems this is ready for merge. Please take out "WIP" in future once ready. Thanks.

@mariobehling mariobehling merged commit 6237676 into fossasia:master Jun 8, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@anshumanv anshumanv deleted the anshumanv:586 branch Jun 8, 2018

@anshumanv

This comment has been minimized.

Copy link
Member Author

commented Jun 8, 2018

@mariobehling this requires fossasia/susi_server#793 to be merged first, since this is merged I'll make the updates as per the API in the next PR. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.