New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parent #448: Implemented a basic News Tab #1023

Merged
merged 1 commit into from Jun 17, 2018

Conversation

2 participants
@praveenojha33
Copy link
Member

praveenojha33 commented Jun 10, 2018

Parent #448

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream master branch.
  • I have added necessary documentation (if appropriate)
  • Added Surge preview link

Changes proposed in this pull request:

  1. In this PR I have created a News Tab which shows result from a single news site(dailymail.co.uk).
  2. I am working on to add multiple news organisation, the changes will be amended to this PR once it is reviewed by other devs.
    Surge:https://pr-1023-fossasia-susper.surge.sh

@praveenojha33 praveenojha33 force-pushed the praveenojha33:news branch from a2f10ac to 407449f Jun 10, 2018

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jun 10, 2018

Codecov Report

Merging #1023 into master will decrease coverage by 0.58%.
The diff coverage is 9.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1023      +/-   ##
==========================================
- Coverage   54.65%   54.06%   -0.59%     
==========================================
  Files          46       46              
  Lines        1182     1193      +11     
  Branches      147      148       +1     
==========================================
- Hits          646      645       -1     
- Misses        446      458      +12     
  Partials       90       90
Impacted Files Coverage Δ
src/app/results/results.component.ts 41.98% <9.09%> (-2.13%) ⬇️
src/app/intelligence/intelligence.component.ts 64% <0%> (-12%) ⬇️
src/app/services/intelligence.service.ts 79.16% <0%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0969cc8...2374bd7. Read the comment docs.

@praveenojha33 praveenojha33 force-pushed the praveenojha33:news branch from 407449f to 2374bd7 Jun 14, 2018

@praveenojha33 praveenojha33 changed the title [WIP] Parent #448: Implemented a basic News Tab Parent #448: Implemented a basic News Tab Jun 16, 2018

@mariobehling mariobehling merged commit bb06cca into fossasia:master Jun 17, 2018

2 of 4 checks passed

codecov/patch 9.09% of diff hit (target 54.65%)
Details
codecov/project 54.06% (-0.59%) compared to 0969cc8
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@praveenojha33 praveenojha33 deleted the praveenojha33:news branch Jun 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment