Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes implement option to customise the result count #546

Merged
merged 1 commit into from Jun 23, 2017

Conversation

3 participants
@nikhilrayaprolu
Copy link
Member

commented Jun 22, 2017

Fixes issue #545
Now result count is customisable
screenshot from 2017-06-23 00-55-53

Demo Link: https://nikhilrayaprolu.github.io/susper.com-1/

@codecov

This comment has been minimized.

Copy link

commented Jun 22, 2017

Codecov Report

Merging #546 into master will decrease coverage by 0.82%.
The diff coverage is 23.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #546      +/-   ##
==========================================
- Coverage   61.33%   60.51%   -0.83%     
==========================================
  Files          36       36              
  Lines         688      704      +16     
  Branches       55       58       +3     
==========================================
+ Hits          422      426       +4     
- Misses        230      241      +11     
- Partials       36       37       +1
Impacted Files Coverage Δ
src/app/searchsettings/searchsettings.component.ts 32.25% <21.42%> (-6.64%) ⬇️
src/app/app.component.ts 62.5% <33.33%> (-4.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88002b9...0524e49. Read the comment docs.

@harshit98
Copy link
Member

left a comment

Working very well! 💯

@harshit98

This comment has been minimized.

Copy link
Member

commented Jun 23, 2017

Kindly edit the title of PR. Fix number is not there.

@mariobehling mariobehling merged commit 2188e27 into fossasia:master Jun 23, 2017

2 of 4 checks passed

codecov/patch 23.52% of diff hit (target 61.33%)
Details
codecov/project 60.51% (-0.83%) compared to 88002b9
Details
codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.