Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #589 speech UI changed #624

Merged
merged 5 commits into from Jul 12, 2017

Conversation

4 participants
@nikhilrayaprolu
Copy link
Member

commented Jul 9, 2017

Fixes issue #589

Demo Link: https://susper-pr-624.herokuapp.com/

For whole working of this feature check this video https://www.youtube.com/watch?v=q1Zy-APxvs4

giphy

@nikhilrayaprolu nikhilrayaprolu temporarily deployed to susper-pr-624 Jul 9, 2017 Inactive

@nikhilrayaprolu nikhilrayaprolu temporarily deployed to susper-pr-624 Jul 9, 2017 Inactive

@Marauderer97

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2017

@nikhilrayaprolu Please check why travis is failing

@nikhilrayaprolu nikhilrayaprolu temporarily deployed to susper-pr-624 Jul 9, 2017 Inactive

@nikhilrayaprolu nikhilrayaprolu temporarily deployed to susper-pr-624 Jul 10, 2017 Inactive

@nikhilrayaprolu

This comment has been minimized.

Copy link
Member Author

commented Jul 10, 2017

@codecov

This comment has been minimized.

Copy link

commented Jul 10, 2017

Codecov Report

Merging #624 into master will decrease coverage by 0.01%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #624      +/-   ##
==========================================
- Coverage   61.31%   61.29%   -0.02%     
==========================================
  Files          42       45       +3     
  Lines         809      881      +72     
  Branches       75       80       +5     
==========================================
+ Hits          496      540      +44     
- Misses        262      292      +30     
+ Partials       51       49       -2
Impacted Files Coverage Δ
src/app/speech.service.ts 87.5% <ø> (+58.08%) ⬆️
src/app/shared/mocks/search.mock.ts 100% <ø> (ø) ⬆️
src/app/reducers/index.ts 93.1% <100%> (+0.79%) ⬆️
src/app/app.component.ts 64% <100%> (+1.5%) ⬆️
src/app/index/index.component.ts 92.85% <100%> (+1.19%) ⬆️
src/app/speechtotext/speechtotext.component.ts 47.36% <47.36%> (ø)
src/app/search-bar/search-bar.component.ts 54.54% <66.66%> (+3.63%) ⬆️
src/app/actions/speech.ts 66.66% <66.66%> (ø)
src/app/reducers/speech.ts 70% <70%> (ø)
src/app/searchsettings/searchsettings.component.ts 32.25% <0%> (-22.59%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1697c8...3507bec. Read the comment docs.

@nikhilrayaprolu

This comment has been minimized.

Copy link
Member Author

commented Jul 10, 2017

@Marauderer97 travis fixed

@harshit98
Copy link
Member

left a comment

LGTM. Kindly fix Travis issue. :)

@mariobehling

This comment has been minimized.

Copy link
Member

commented Jul 10, 2017

Please resolve conflicts.

@mariobehling
Copy link
Member

left a comment

Currently not working for me - when I finish with the sentence it does not go automatically to the search result page.

Secondly the sound indicator behind the red button is not aligned in all resolutions.
screenshot from 2017-07-10 20-03-12

@Marauderer97
Copy link
Contributor

left a comment

image
The sound button is hidden in the mobile view

@mariobehling

This comment has been minimized.

Copy link
Member

commented Jul 12, 2017

Please resolve conflicts.

@mariobehling

This comment has been minimized.

Copy link
Member

commented Jul 12, 2017

Ok, I am merging this as work in progress. Let's try it on the live site. I think there are still issues.

@mariobehling mariobehling merged commit 0209802 into fossasia:master Jul 12, 2017

1 check passed

codacy/pr Good work! A positive pull request.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.