New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #648: Listening...message added to speech UI #663

Merged
merged 2 commits into from Jul 18, 2017

Conversation

3 participants
@harshit98
Member

harshit98 commented Jul 17, 2017

Fixes issue #648

Changes:

  • Added "Listening..." message similar to market leader in speech UI.
  • @nikhilrayaprolu I have done the changes as requested in PR #652 , now the message won't appear every time.

Demo Link: https://harshit98.github.io/susper.com/

This PR has been made with reference to PR : #652

Kindly review @nikhilrayaprolu @Marauderer97 @mariobehling

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Jul 17, 2017

Codecov Report

Merging #663 into master will decrease coverage by 0.13%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #663      +/-   ##
==========================================
- Coverage   61.36%   61.22%   -0.14%     
==========================================
  Files          45       45              
  Lines         911      913       +2     
  Branches       87       88       +1     
==========================================
  Hits          559      559              
- Misses        297      299       +2     
  Partials       55       55
Impacted Files Coverage Δ
src/app/speechtotext/speechtotext.component.ts 42.02% <33.33%> (-1.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f74b5a...6bf7c94. Read the comment docs.

codecov bot commented Jul 17, 2017

Codecov Report

Merging #663 into master will decrease coverage by 0.13%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #663      +/-   ##
==========================================
- Coverage   61.36%   61.22%   -0.14%     
==========================================
  Files          45       45              
  Lines         911      913       +2     
  Branches       87       88       +1     
==========================================
  Hits          559      559              
- Misses        297      299       +2     
  Partials       55       55
Impacted Files Coverage Δ
src/app/speechtotext/speechtotext.component.ts 42.02% <33.33%> (-1.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f74b5a...6bf7c94. Read the comment docs.

@nikhilrayaprolu

@harshit98 transition effect here mean displaying a letter after a letter. if you check google, google doesn't display whole 'Listening...' in one go. it displays first 'L' and then 'Li' and then 'Lis' and so on. these are basically called as text transitions and you can make them using css3, one example of it is at https://codemyui.com/auto-type-content-pure-css/

@nikhilrayaprolu

This comment has been minimized.

Show comment
Hide comment
@nikhilrayaprolu

nikhilrayaprolu Jul 18, 2017

Member

@harshit98 great work regarding the text effect. please look at my comment, just a small change is left.

Member

nikhilrayaprolu commented Jul 18, 2017

@harshit98 great work regarding the text effect. please look at my comment, just a small change is left.

Fixes #648: Listening...message added to speech UI
Applied transition effect

Add animation delay

Fix timer
@harshit98

This comment has been minimized.

Show comment
Hide comment
@harshit98
Member

harshit98 commented Jul 18, 2017

@nikhilrayaprolu nikhilrayaprolu merged commit 9d029fd into fossasia:master Jul 18, 2017

2 of 4 checks passed

codecov/patch 33.33% of diff hit (target 61.36%)
Details
codecov/project 61.22% (-0.14%) compared to 8f74b5a
Details
codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment