Restructure project + server plugins #837
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuelScheit
force-pushed
the
dev/plugins
branch
from
6604169
to
5f165fd
Compare
erkinalp
suggested changes
Aug 13, 2022
Closed
3 tasks
erkinalp
suggested changes
Aug 13, 2022
There was a problem hiding this comment.
@TheArcaneBrony pointed out there is no way to restrict a plugin's capability with this PR
one should be able to restrict which components and users the plugin can act on
|
This could be resolved by having an "official" plugin repository, with plugins that are checked and verified to be following policies and not doing dodgy things. For externally sourced plugins, it would be up to the user to read and understand the code. |
TheArcaneBrony
force-pushed
the
dev/plugins
branch
7 times, most recently
from
99d453a
to
5473e07
Compare
TheArcaneBrony
force-pushed
the
dev/plugins
branch
5 times, most recently
from
fafd950
to
b1bd129
Compare
TheArcaneBrony
force-pushed
the
dev/plugins
branch
3 times, most recently
from
a44087b
to
192dbca
Compare
TheArcaneBrony
force-pushed
the
staging
branch
from
401eda0
to
baeec00
Compare
TheArcaneBrony
force-pushed
the
dev/plugins
branch
5 times, most recently
from
a7b2946
to
285fb6a
Compare
TheArcaneBrony
force-pushed
the
dev/plugins
branch
from
285fb6a
to
606a710
Compare
http error data field, migrations
fixup! Cleanup, reformat, fix some todos, git hook
TheArcaneBrony
force-pushed
the
dev/plugins
branch
from
606a710
to
5c146b1
Compare
|
Gonna close this for now, because the only relevant part now is the plugin system. Should make a new PR with just the plugin system code at some point, if we still want server plugins? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assignments
samuel: code
matteo, arcane, erkinalp: review
cat: documentation