You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Do not link a pull request to this issue(e.g. Closes #1).
Currently, as we look at the repository in our org, each workflow is written in a messy way.
For example, the check-commit-message workflow is a duplicate of the same code for each repository.
check-commit-message:
name: Check Commit Messageruns-on: ubuntu-lateststeps:
- name: Get PR Commitsid: 'get-pr-commits'uses: tim-actions/get-pr-commits@masterwith:
token: ${{ secrets.GITHUB_TOKEN }}
- name: Check Subject Line Lengthuses: tim-actions/commit-message-checker-with-regex@v0.3.1with:
commits: ${{ steps.get-pr-commits.outputs.commits }}pattern: '^.{0,50}(\n.*)*$'error: 'Subject too long (max 50)'
- name: Check Body Line Lengthif: ${{ success() || failure() }}uses: tim-actions/commit-message-checker-with-regex@v0.3.1with:
commits: ${{ steps.get-pr-commits.outputs.commits }}pattern: '^.+(\n.{0,72})*$'error: 'Body line too long (max 72)'
Duplicate workflows make maintenance difficult and increase the potential for human error.
Rather than using workflow files for each trigger event, we should separate them by functionality and see what we can abstract away along the way.
The text was updated successfully, but these errors were encountered:
proposal: Divide and abstract complex workflows
Important
Do not link a pull request to this issue(e.g. Closes #1).
Currently, as we look at the repository in our org, each workflow is written in a messy way.
For example, the
check-commit-message
workflow is a duplicate of the same code for each repository.Duplicate workflows make maintenance difficult and increase the potential for human error.
Rather than using workflow files for each trigger event, we should separate them by functionality and see what we can abstract away along the way.
The text was updated successfully, but these errors were encountered: