Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(atarashi): Add Atarashi to FOSSology #1408

Merged
merged 51 commits into from Feb 26, 2020

Conversation

hastagAB
Copy link
Member

Description

Integrating Atarashi with FOSSology. Currently, Atarashi works as a stand-alone scanner for various OSS licenses. It needs to be integrated with the main FOSSology Software to have better usage.

Changes

Changed Ninka codebase according per the need to integrate Atarashi with FOSSology.

How to test

Do a fresh installation of the FOSSology software from source.

Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
This commit adds a weak dependency on postgresql on start.
Also register FOSSology init.d to run time using update-rc.d

Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
1. Copyright agent can not be scheduled from API.
2. Get /users/ always return same result.
3. Add parent folder id to the folder model.

Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
Show the text findings done manually by the user in copyright-hist
view in the UI.

Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
@ag4ums ag4ums added the WIP label Jul 23, 2019
1. Fix infinite loop in dbmigrate_3.5-3.6.php
2. Do not check pfile_sha256 in ununpack and wget during insertion
as the column is still optional and can be NULL in some cases.
3. Upper case all pfile_sha256 to match schema.

Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
@ag4ums
Copy link
Contributor

ag4ums commented Jul 23, 2019

@hastagAB can you please cherry-pick the commits from here
GMishx@3b31c17

hastagAB and others added 2 commits July 24, 2019 01:49
Revert "solve merge conflicts"

This reverts commit b811654.
Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
…pecification

fix(api): Adhere to specification
       tested and reviewed by : anupam.ghosh@siemens.com
…from-dirs

fix(build): Fix clean build from all dirs
     Tested By : anupam.ghosh@siemens.com
     Reviewed By : anupam.ghosh@siemens.com
@ag4ums
Copy link
Contributor

ag4ums commented Jul 30, 2019

@hastagAB please fix the failing test cases..

image

mcjaeger and others added 17 commits August 2, 2019 08:15
…ndings-ui-hist

feat(copyright): Show text findings in copyright-hist

review-by:shaheem.azmal@siemens.com
tested-by:michael.c.jaeger@siemens.com
The agent uses regex to find SPDX-License-Identifier and report all
the licenses found.
The agent can be used in stand alone mode as well.

Signed-off-by: Anupam Ghosh <anupam.ghosh@siemens.com>
Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
Signed-off-by: Shaheem Azmal M MD <shaheem.azmal@siemens.com>
Added Functional, Unit and regression test cases.

Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
feat(new-agent): license scanner for SPDX-License-Identifier
       Reviewed by : anupam.ghosh@siemens.com
       Tested by :  anupam.ghosh@siemens.com, michael.c.jaeger@siemens.com
Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
…ixes

chore(debian): Fix lintian erros and warnings

tested-by:anupam.ghosh@siemens.com
review-by:anupam.ghosh@siemens.com
…ng-updatercd

fix(init.d): Implement missing function

review-by:anupam.ghosh@siemens.com
tested-by:anupam.ghosh@siemens.com,michael.c.jaeger@siemens.com
existing licenses from SPDX

Signed-off-by: Shaheem Azmal M MD <shaheem.azmal@gmail.com>
fix(pfile): SHA256 is still optional
Reviewed-by: shaheem.azmal@siemens.com,
Tested-by: shaheem.azmal@siemens.com
Fix the #!/usr/bin/env php comming at top of every PHP file

Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
…sFromPhp

hotfix(process): Fix the PHP agent installation
     reviewed by : maximilian.huber@tngtech.com
     tested by : anupam.ghosh@siemens.com
Update systemd configuration before starting the init.d script,
so that systemd generates the missing fossology.service in time.

Signed-off-by: Andreas J. Reichel <andreas.reichel@tngtech.com>
…nsesFromSPDX

feat(licenseRef): add new functionality to add new licenses and update 

tested-by:michael.c.jaeger@siemens.com
review-by:michael.c.jaeger@siemens.com
Adding changelog files for 3.6.0-rc1 pre-release
sudo add-apt-repository ppa:deadsnakes/ppa
sudo apt-get update
sudo apt-get install python>=3.6

Copy link
Contributor

@ag4ums ag4ums Aug 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • This installation script can be move to agent's mod_deps file(not in its current form), as different distro support different version of installed package.
  • Also please install pip using distro default install method (eg : apt-get install python3-pip for ubuntu)
    and then upgrade the pip to its current version
  • You can use this script as a ref https://github.com/fossology/fossology/blob/master/src/ojo/mod_deps

@GMishx GMishx added the GSOC-19 label Aug 20, 2019
GMishx and others added 21 commits August 20, 2019 05:30
feat(unifiedreport): add candidate licenses to the list of obligations

Reviewed-by: anupam.ghosh@siemens.com
Tested-by: mishra.gaurav@siemens.com
…ication is empty

Signed-off-by: Shaheem Azmal M MD <shaheem.azmal@siemens.com>
Check if empty decision type sent for manual copyright findings.

Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
fix(obligation): add default value if the obligation type and classif…

Reviewed-by: mishra.gaurav@siemens.com
Tested-by: mishra.gaurav@siemens.com
…try-withoutDecision

fix(copyright): Check if empty decision sent
Reviewed-by: shaheem.azmal@siemens.com
Tested-by: michael.c.jaeger@siemens.com, shaheem.azmal@siemens.com
Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
…rBuilder

fix(ojo): Remove call to omitEndingLineFeed on json cpp < 0.7
    Tested by : anupam.ghosh@siemens.com
    Reviewed by :  by : anupam.ghosh@siemens.com
Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
fix(dbMigrate): Fix PHP syntax error
Tested-by: shaheem.azmal@siemens.com
Reviewed-by: shaheem.azmal@siemens.com
Signed-off-by: Anupam Ghosh <anupam.ghosh@siemens.com>
chore(changelog): adding 3.6.0-rc2 info to changelog files

Reviewed-by: mishra.gaurav@siemens.com
fix(copyright): show more than 100 copyrights on one page
Tested-by: mishra.gaurav@siemens.com
Reviewed-by: mishra.gaurav@siemens.com, shaheem.azmal@siemens.com
@GMishx
Copy link
Member

GMishx commented Oct 15, 2019

Hello @hastagAB,
Did you get time to look into the the CI failures?

Do let us know if you need any kind of help.

@hastagAB
Copy link
Member Author

The make command for agent and test was working fine. The CI shows error with the atarashi command.

@ag4ums ag4ums changed the base branch from master to feat/newagent/atarashi February 26, 2020 10:52
@ag4ums ag4ums merged commit d7cecd6 into fossology:feat/newagent/atarashi Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants