Definition of Done

Michael edited this page May 2, 2016 · 6 revisions

The definition of done helps to set a common understanding for solving a ticket.

Definition of done policy

  • Review points should involve one person from another angle (not just the person you were sitting together with anyways)
  • Limit items in review to 5, try to coordinate

Using Github assignments to issues or pull requests

then the mailing list

  • Open review items requires mailing list

Definition of done items

  • File headers in file OK

  • GPLv2 License (see code style)

  • Or, if the file is too small, configuration file: license note (see code style)

  • Copyright and Author

  • Avoid (seriously) compiler warnings

  • Fast forward merge to master

  • That means that merge to master is prepared

  • No breaking test

  • Unit, php and c

  • You have more - use them!

  • New test

  • For new / added functionality

  • Documentation

  • in the Githuib Wiki-Section if you have done something new

  • Review

  • Code style

  • DoD items reached

  • Design / architecture issues

  • Upstream / fossology community contribution suitability

  • Ticket coverage (does it actually solve the problem?)

Clone this wiki locally
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.
Press h to open a hovercard with more details.