Permalink
Browse files

Item14349: Edit table button doesn't work on IE 11.

Thanks to Crawford Currie for the fix.
  • Loading branch information...
gac410 committed May 1, 2017
1 parent 9f18364 commit 3f7c5f26e918483e2a22be3cbe6fb0b065d15d6b
@@ -1,4 +1,4 @@
%META:TOPICINFO{author="ProjectContributor" comment="" date="1491353402" format="1.1" version="1"}%
%META:TOPICINFO{author="ProjectContributor" comment="" date="1493666715" format="1.1" version="1"}%
---+!! !EditRowPlugin
<!--
One line description, required for extensions repository catalog.
@@ -271,7 +271,8 @@ Provides the vertical row editing interface like
Another great Foswiki extension from the <a style="text-decoration:none" href="http://wikiring.com"><img src="%ATTACHURLPATH%/wikiringlogo20x20.png" alt="" /> *WikiRing* </a> - working together to improve your wiki experience!
| Change History: | <!-- versions below in reverse order -->&nbsp; |
| 3.318 (4 Apr 2017) | Foswikitask:Item14351: uninitialized value warning when changerows is used with EditRowPlugin |
| 3.318 (1 May 2017) | Foswikitask:Item14351: Uninitialized value warning when changerows is used with EditRowPlugin <br/>\
Foswikitask:Item14349: Edit Table button not functional on IE 11.|
| 3.317 (21 Jan 2017) | Foswikitask:Item14107 Document that move, add & delete row actions are immediate, not subject to cancel. |
| 3.316 (26 Nov 2016) | Foswikitask:Item14174 css.gz and js.gz files missing from MANIFEST<br/> \
Foswikitask:Item14213 Warning logged about uninitialized values <br/>\
@@ -351,17 +352,17 @@ Another great Foswiki extension from the <a style="text-decoration:none" href="h
%META:FIELD{name="License" title="License" value="[[http://www.gnu.org/licenses/gpl.html][GPL (Gnu General Public License)]]"}%
%META:FIELD{name="Home" title="Home" value="http://foswiki.org/Extensions/EditRowPlugin"}%
%META:FIELD{name="Support" title="Support" value="http://foswiki.org/Support/EditRowPlugin"}%
%META:FILEATTACHMENT{name="icons.png" attr="h" comment="" date="1491353402" size="2457" user="ProjectContributor" version="1"}%
%META:FILEATTACHMENT{name="example3.png" attr="h" comment="" date="1491353402" size="15337" user="ProjectContributor" version="1"}%
%META:FILEATTACHMENT{name="example4.png" attr="h" comment="" date="1491353402" size="22834" user="ProjectContributor" version="1"}%
%META:FILEATTACHMENT{name="erp.css" attr="h" comment="" date="1491353402" size="1454" user="ProjectContributor" version="1"}%
%META:FILEATTACHMENT{name="screenshot2.png" attr="h" comment="" date="1491353402" size="12013" user="ProjectContributor" version="1"}%
%META:FILEATTACHMENT{name="TableSort.uncompressed.js" attr="h" comment="" date="1491353402" size="6803" user="ProjectContributor" version="1"}%
%META:FILEATTACHMENT{name="erp.js" attr="h" comment="" date="1491353402" size="11898" user="ProjectContributor" version="1"}%
%META:FILEATTACHMENT{name="erp.uncompressed.css" attr="h" comment="" date="1491353402" size="2130" user="ProjectContributor" version="1"}%
%META:FILEATTACHMENT{name="example5.png" attr="h" comment="" date="1491353402" size="9132" user="ProjectContributor" version="1"}%
%META:FILEATTACHMENT{name="erp.uncompressed.js" attr="h" comment="" date="1491353402" size="26625" user="ProjectContributor" version="1"}%
%META:FILEATTACHMENT{name="screenshot1.png" attr="h" comment="" date="1491353402" size="19461" user="ProjectContributor" version="1"}%
%META:FILEATTACHMENT{name="TableSort.js" attr="h" comment="" date="1491353402" size="3626" user="ProjectContributor" version="1"}%
%META:FILEATTACHMENT{name="wikiringlogo20x20.png" attr="h" comment="" date="1491353402" size="1343" user="ProjectContributor" version="1"}%
%META:FILEATTACHMENT{name="clock.gif" attr="h" comment="" date="1491353402" size="1418" user="ProjectContributor" version="1"}%
%META:FILEATTACHMENT{name="icons.png" attr="h" comment="" date="1493666715" size="2457" user="ProjectContributor" version="1"}%
%META:FILEATTACHMENT{name="example3.png" attr="h" comment="" date="1493666715" size="15337" user="ProjectContributor" version="1"}%
%META:FILEATTACHMENT{name="example4.png" attr="h" comment="" date="1493666715" size="22834" user="ProjectContributor" version="1"}%
%META:FILEATTACHMENT{name="erp.css" attr="h" comment="" date="1493666715" size="1454" user="ProjectContributor" version="1"}%
%META:FILEATTACHMENT{name="screenshot2.png" attr="h" comment="" date="1493666715" size="12013" user="ProjectContributor" version="1"}%
%META:FILEATTACHMENT{name="TableSort.uncompressed.js" attr="h" comment="" date="1493666715" size="6803" user="ProjectContributor" version="1"}%
%META:FILEATTACHMENT{name="erp.js" attr="h" comment="" date="1493666715" size="11898" user="ProjectContributor" version="1"}%
%META:FILEATTACHMENT{name="erp.uncompressed.css" attr="h" comment="" date="1493666715" size="2130" user="ProjectContributor" version="1"}%
%META:FILEATTACHMENT{name="example5.png" attr="h" comment="" date="1493666715" size="9132" user="ProjectContributor" version="1"}%
%META:FILEATTACHMENT{name="erp.uncompressed.js" attr="h" comment="" date="1493666715" size="26625" user="ProjectContributor" version="1"}%
%META:FILEATTACHMENT{name="screenshot1.png" attr="h" comment="" date="1493666715" size="19461" user="ProjectContributor" version="1"}%
%META:FILEATTACHMENT{name="TableSort.js" attr="h" comment="" date="1493666715" size="3626" user="ProjectContributor" version="1"}%
%META:FILEATTACHMENT{name="wikiringlogo20x20.png" attr="h" comment="" date="1493666715" size="1343" user="ProjectContributor" version="1"}%
%META:FILEATTACHMENT{name="clock.gif" attr="h" comment="" date="1493666715" size="1418" user="ProjectContributor" version="1"}%
@@ -33,7 +33,7 @@ BEGIN {
}
our $VERSION = '3.318';
our $RELEASE = '04 Apr 2017';
our $RELEASE = '01 May 2017';
our $SHORTDESCRIPTION = 'Inline edit for tables';
our $NO_PREFS_IN_TOPIC = 1;
@@ -340,17 +340,8 @@ sub render {
if ( $this->{attrs}->{disable} !~ /full/ ) {
# Full table editing is not disabled
my $title = "Edit full table";
my $button = Foswiki::Render::html(
'button',
{
type => 'button',
name => "erp_edit_${id}",
class => 'erp-edittable',
title => $title
}
);
my $url = Foswiki::Func::getScriptUrl(
my $title = "Edit full table";
my $url = Foswiki::Func::getScriptUrl(
$this->getWeb(), $this->getTopic(), 'view',
erp_topic => $active_topic,
erp_table => $id,
@@ -360,8 +351,16 @@ sub render {
push(
@out,
Foswiki::Render::html( 'a', { name => "erp_${id}" } )
. Foswiki::Render::html( 'a',
{ href => $url, title => $title }, $button )
. Foswiki::Render::html(
'a',
{
href => $url,
name => "erp_edit_${id}",
class => 'erp-edittable foswikiButton',
title => $title
},
''
)
. '<br />'
);
}
@@ -77,8 +77,8 @@ a.erp_drag_button:hover {
}
.erp-edittable {
width: 47px;
height: 20px;
width: 27px;
height: 13px;
background-image: url("icons.png") !important;
background-position:0 -16px;
}

0 comments on commit 3f7c5f2

Please sign in to comment.