Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Item13519: Add a dependency to SubscribePlugin
SubscribePlugin inherits the dependencies of MailerContrib at runtime.
If critical dependencies are missing, foswiki crashes rather than just
disabling the extension.   Add the dependency directly to
SubscribePlugin so that it will be disabled rather than crash.
  • Loading branch information
gac410 committed Oct 9, 2015
1 parent 3b31eb5 commit 4b42485
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions SubscribePlugin/lib/Foswiki/Plugins/SubscribePlugin.pm
Expand Up @@ -18,6 +18,11 @@ use Assert;
use Error ':try';
use JSON ();

# SMELL: SubscribePlugin requires MailerContrib, which requires URI. Require URI at compile time, so that SUBSCRIBE
# is disabled if MailerContrib is missinng the dependency. Otherwise Foswiki crashes when trying to render the
# SUBSCRIBE macro.
use URI ();

our $VERSION = '3.4';
our $RELEASE = '27 Jul 2015';
our $SHORTDESCRIPTION =
Expand Down

0 comments on commit 4b42485

Please sign in to comment.