From 6b6b4c8a00b72c9a293e4e8e189d96b54255b33b Mon Sep 17 00:00:00 2001 From: CrawfordCurrie Date: Mon, 6 Sep 2010 13:38:10 +0000 Subject: [PATCH] Item9629: After validation, a multi-valued param that has no value can end up with an undef value. Also committing a debugging enhancement that helps you track down the source of oops exceptions git-svn-id: http://svn.foswiki.org/trunk@8933 0b4bb1d4-4e5a-0410-9cc4-b2b747904278 --- core/lib/Foswiki/Form/FieldDefinition.pm | 2 +- core/lib/Foswiki/OopsException.pm | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/core/lib/Foswiki/Form/FieldDefinition.pm b/core/lib/Foswiki/Form/FieldDefinition.pm index a203ec6835..13e6e20c21 100644 --- a/core/lib/Foswiki/Form/FieldDefinition.pm +++ b/core/lib/Foswiki/Form/FieldDefinition.pm @@ -239,7 +239,7 @@ sub populateMetaFromQueryData { if ( $this->isMultiValued() ) { my @values = $query->param( $this->{name} ); - if ( scalar(@values) == 1 ) { + if ( scalar(@values) == 1 && defined $values[0] ) { @values = split( /,|%2C/, $values[0] ); } my %vset = (); diff --git a/core/lib/Foswiki/OopsException.pm b/core/lib/Foswiki/OopsException.pm index be8ce031ae..6a1ee2b208 100644 --- a/core/lib/Foswiki/OopsException.pm +++ b/core/lib/Foswiki/OopsException.pm @@ -181,7 +181,7 @@ sub stringify { if ( defined $this->{params} ) { $s .= ' params=>[' . join( ',', @{ $this->{params} } ) . ']'; } - return $s . ')'; + return $s . ')'.((DEBUG)?$this->stacktrace:''); } }