Item10076: Guess the bin directory correctly

And don't create working directory until guessed settings are saved.

git-svn-id: http://svn.foswiki.org/trunk@10061 0b4bb1d4-4e5a-0410-9cc4-b2b747904278

core/lib/Foswiki/Configure/Checker.pm

@@ -102,9 +102,10 @@ sub guessMajorDir {
     if ( !$Foswiki::cfg{$cfg} || $Foswiki::cfg{$cfg} eq 'NOT SET' ) {
         require FindBin;
         $FindBin::Bin =~ /^(.*)$/;
-        my @root = File::Spec->splitdir($1);
+        my $scriptDir = $1;
+        my @root = File::Spec->splitdir($scriptDir);
         pop(@root);
-        $Foswiki::cfg{$cfg} = File::Spec->catfile( @root, $dir );
+        $Foswiki::cfg{$cfg} = ( $cfg eq 'ScriptDir') ? $scriptDir : File::Spec->catfile( @root, $dir );
         $Foswiki::cfg{$cfg} =~ s|\\|/|g;
         $msg = $this->guessed();
     }

core/lib/Foswiki/Configure/Checkers/WorkingDir.pm

@@ -20,6 +20,12 @@ sub check {
     #my $saveumask = umask();
     #umask ( oct(000));
 
+    if ( $mess ) {
+        $mess .= $this->NOTE('This directory will be created after the guessed settings are saved') unless (-d "$Foswiki::cfg{WorkingDir}" );
+        return $mess;   # guess will return message if a guess is made.
+    }
+
+
     unless ( -d "$Foswiki::cfg{WorkingDir}" ) {
         mkdir("$Foswiki::cfg{WorkingDir}", oct(755) )
           || return $this->ERROR(