Item1960: Item2609: extender.pl broken - Plugin installation fails if…

… using tar instead of Archive::Tar

Found out that Item1960 is a duplicate of Item2609


git-svn-id: http://svn.foswiki.org/trunk@5984 0b4bb1d4-4e5a-0410-9cc4-b2b747904278

core/tools/extender.pl

@@ -636,7 +636,10 @@ sub untar {
         }
         for my $tarBin ( qw( tar gtar ) ) {
             _warn "Trying $tarBin on the command-line\n";
-            system $tarBin, "xvf$compressed", $archive and return 1;
+            # system call returns 0 if success. and error code if no success
+            # so we return 1 if the tarBin call succeed
+            return 1 unless system $tarBin, "xvf$compressed", $archive;
+            # OK we failed. Report and loop on if more to loop
             if ($?) {
                 _warn "$tarBin failed: $?";
             }