FireTray for GTK3 #182

Closed
Temlakos opened this Issue May 27, 2015 · 17 comments

Projects

None yet

5 participants

@Temlakos

Firefox cannot run with FireTray 0.5.6 enabled. It crashes on startup every time. I had to start Firefox in safe mode and disable FireTray to get Firefox to run at all.

This could relate to the other issue I created, namely that FireTray's system tray icons are not suitable for use in KDE Plasma 5 and simply do not appear. I had to use a third-party tray even to see the FireTray icon for Thunderbird. (Thunderbird does not crash with FireTray in place.)

The Fedora Project just released F22. Its new KDE spin jumped to Plasma 5 from KDE 4. That's why I am only now noticing this issue. But you will likely see a lot of reports on this as a lot of unhappy campers try to start Firefox in the new environment only to find they cannot.

@foudfou
Owner
foudfou commented May 28, 2015

Thx for reporting. I could reproduce the problem in a fresh F22 virtual machine.
The relevant part is:

(firefox:23724): GLib-GObject-WARNING **: cannot register existing type 'GdkDisplay'
(firefox:23724): GLib-CRITICAL **: g_once_init_leave: assertion 'result != 0' failed
(firefox:23724): Gdk-CRITICAL **: IA__gdk_x11_display_get_xdisplay: assertion 'GDK_IS_DISPLAY (display)' failed

And the problem is gdk_display_get_default() is returning NULL. But I don't know why yet.

@Temlakos

OK, so it wasn't my imagination. Nor my one machine, either. But I knew that: I saw this problem on two different machines, this after upgrading from F21 to F22.

As I said, FireTray 0.5.6 still runs with Thunderbird. And when I install "wmsystemtray," I get the same fully functioning system tray icon I'm used to seeing, that displays the number of unread messages. It's just that I have to see that in a tiny window off in a corner somewhere, and usually hidden, because I like to run Firefox and Thunderbird full-screen.

@DavidPrevot

Hi,

I believe a similar issue has just been reported on Debian: https://bugs.debian.org/787803

“Some investigating with GDB shows GTK3 symbols in the stack being mixed with the GTK2 which [Thunderbird/Firefox] use.”

@foudfou
Owner
foudfou commented Jun 9, 2015

Thank you @DavidPrevot and @gcp !! It looks like I should use libappindicator1 instead of libappindicator3. Wonder how it used to work previously... Will fix that ASAP.

@Temlakos
Temlakos commented Jun 9, 2015

Would that possibly solve the issue of FireTray's icons not playing nice with KDE's new Plasma 5 system tray?

@foudfou
Owner
foudfou commented Jun 9, 2015

Not exactly: we need another lib for that, or libappindicator to implement missing features.

@foudfou
Owner
foudfou commented Jun 21, 2015

Switching to libappindicator1 doesn't help much. You can check the indicator1 branch.
Obviously GTK3 libs are still loaded, even with FireTray disabled (as shown by lsof). This may be because of the GTK theme in KDE, if any. But I don't know how to change that.

@foudfou
Owner
foudfou commented Jun 21, 2015

After some digging, it appears Firefox 38.0 in Fedora22 is the GTK3 build, already. And since GTK2 and GTK3 cannot be loaded together, obviously FireTray needs to be ported to GTK3.

I'm updating the subject of this thread to reflect the real problem.

@foudfou foudfou changed the title from FireTray 0.5.6 crashes Firefox on startup in KDE Plasma 5 to FireTray for GTK3 (was: FireTray 0.5.6 crashes Firefox on startup in KDE Plasma 5) Jun 21, 2015
@foudfou foudfou changed the title from FireTray for GTK3 (was: FireTray 0.5.6 crashes Firefox on startup in KDE Plasma 5) to FireTray for GTK3 Jun 21, 2015
@foudfou
Owner
foudfou commented Jun 21, 2015

Intersting post about Firefox, GTK3 and plugins.

@HanFox
HanFox commented Aug 15, 2015

Thunderbird Earlybird (Aurora) 42.0a2 now also crashes when FireTray is loaded.

@foudfou
Owner
foudfou commented Aug 17, 2015

Gtk3 support added. See the 4d9816e and the gtk3 branch.

@HanFox
HanFox commented Aug 18, 2015

Nice. The gtk3 branch seems to be working well in Earlybird. Thanks for the great addon 👍

@inguin
inguin commented Aug 20, 2015

GTK3 version does not work on my system: No tray icon appears, and the Preferences dialog lacks the Mail and Chat tabs. A build from the master branch works flawlessly.

System details:

  • Fedora 21, x86-64
  • KDE 4.14.9
  • Thunderbird 38.1.0
@HanFox
HanFox commented Aug 20, 2015

@inguin: do you have libappindicator-gtk3 installed? If not, try it.

@inguin
inguin commented Aug 20, 2015

Yes, it's installed. It wasn't installed when I first built the add-on, though, so there is a chance that something wasn't properly updated.

@inguin
inguin commented Aug 20, 2015

Found it: The Makefile must be updated to include the new directories ctypes/linux/gtk[23] in modules_sources.

@foudfou
Owner
foudfou commented Aug 20, 2015

@inguin my bad! Fixed in 96c0862. Thank you.

@foudfou foudfou closed this Oct 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment