Add show+raise+openChatTab click handler on chat icon #60

Open
simonbcn opened this Issue Sep 8, 2012 · 10 comments

Projects

None yet

4 participants

@simonbcn

I have updated to version 0.4.3.
It displays an icon green for the chat. I suposse that this color means that I'm connected. But when I click on it, it does nothing. Shouldn't it open the chat window?

@foudfou
Owner

:) The Chat icon has "limited" functionality for now. It only displays the user status and when she gets direct messages or is cited in a channel. It took me already quite some efforts to achieve that :)

I can try to add an open-chat-tab-and-present-it click handler if you think it is useful (and a command line option while I'm at it). Do you think v0.4.3 (not released yet) should wait for this functionality ?

@simonbcn

I think it would be useful. When I receive new mail, I click in mail icon and it opens the mail window. Logically, the chat button should do the same with the chat window, don't you think?
By other side, what are the status colors of the chat icon?
Regards.

@foudfou
Owner

Just to make sure: middle-click on mail icon ? So it should also be middle-click on chat icon ?

Do you think v0.4.3 (not released yet) should wait for this functionality ?

@simonbcn

middle-click? I use left-click on tray icon to open/close Thunderbird.

Do you think v0.4.3 (not released yet) should wait for this functionality ?

If developing this new feature will take you a long time, I would release the 0.4.3 before.

@foudfou
Owner

I think I'll concentrate on the current release candidate then, and include your proposal in a next version.

Middle-click "presents" or raises the last TB window. This is useful when using multiple desktops/workspaces. Depending on the WM, it shows the last TB window in the current workspace, or switches the workspace to the last TB window, or nothing.

So what should left-click on chat icon do in your opinion ? Show + raise + open-chat-tab ?

@simonbcn

Ok, I didn't know the middle-click function. I use Gnome-shell 3.4.1 and left-click works well for me.

So what should left-click on chat icon do in your opinion ? Show + raise + open-chat-tab ?

IMHO, yes.

@foudfou
Owner

I forgot to answer your question about the chat icon colors.
The chat icon uses the following Gtk themed icons: user-available, user-away, user-busy, user-offline. You should find samples in /usr/share/icons/gnome/*/status.
These names are currently hard-coded.

@adefaria

I agree that left click should open the chat window of Thunderbird and if at all possible zoom you into the last chat message that came through (or perhaps the first).

Also, right now, if I get a message the chat icon blinks. But if I acknowledge the message by going to it and reading it the blinking doesn't stop! Actually nothing makes the blinking stop except restarting Thunderbird or going into FireTray's preferences and toggling off then back on the enable chat icon.

Ideally, however, there should be no chat icon. Instead the messages should participate in the notification-daemon (perhaps this is only on Ubuntu) or otherwise notify the user that a message has been received. It really doesn't matter if it's a chat message or an email message - it's a message and should be handled similarly. When you get an email message the icon changes to that of a letter. Perhaps if you get a chat message another icon could be shown and if you have both new mail and a new chat message maybe a 3rd icon that indicates you have both new email and a new chat message to attend to.

@foudfou
Owner

@adefaria the chat icon blinking issue has been fixed (see #61). You can build the last version while waiting it to be released on addons.mozilla.org.

@RalfJung

I agree that "show on click" is such a standard behavior for tray icons (FireTray itself implements it for its "main" icon) that one really expects the chat icon to do the same: Clicking on it, show show Thunderbird. If it can show the chat tab, even better. But currently, when the chat icon blinks, I have to click another icon to read the chat message. That's kind of confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment