Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide class has an !important rule now #6024

Closed
giroin opened this issue Nov 12, 2014 · 7 comments
Closed

hide class has an !important rule now #6024

giroin opened this issue Nov 12, 2014 · 7 comments
Labels

Comments

@giroin
Copy link

giroin commented Nov 12, 2014

In foundation 5.4.7 version you changed .hide css class to have
.hide {
display: none !important;
visibility: hidden;
}

instead of the previous

.hide {
display: none; }

That makes our life much harder now, we had to go back to our project and overwrite all of them. When you use !important is not easy to do it.

@abrookbanks
Copy link

This has broken most of my JQuery animations. (slideDown, show etc...)

I had used class="hide" instead of style="display: none".

@rafibomb
Copy link
Member

rafibomb commented Dec 9, 2014

Visibility classes need important because they are too easy to override.

@rafibomb rafibomb closed this as completed Dec 9, 2014
@wolfgang-demeter
Copy link
Contributor

Is there any plausible reason for that?
If you don't want something to potentially show up, simply don't output/render it! But don't use .hide for that. And please don't break the backwards-compatibillity of a widely used class like .hide - especially with numerous JS/jquery functions & plugins - so that everybody has to refactor their code.
If you really want such an class, create a new one like .hide-forever, .secret, .bury or whatever!

@giroin
Copy link
Author

giroin commented Dec 11, 2014

Totally agree with wolfgang-demeter !!!

@jondkinney
Copy link

I'm filtering all the curse words at the moment... give me my old .hide back please!!!!!!!!!!!!!

@wolfgang-demeter
Copy link
Contributor

@rafibomb Is there any update on that matter?

@nblum
Copy link

nblum commented Jan 9, 2015

an important in a framework stylesheet is realy ugly... can't understand this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants