Feature #9592: CSS Dropcaps, v6 #9609

IamManchanda · 2017-01-05T17:33:14Z

Implementation for: #9592
Forwarded from: #9606 ( Due to branching issue )

This adds a new feature CSS Dropcaps,
Simply use a dropcaps class in any html tag and the first letter of the text collection will grow to a bigger size proportionate to 3 normal lines and is as similar to what is found in magazines and the modern web

@ncoden @kball for review

Update: Here is the updated code from the below humongous code discussion b/w me & Nicolas

The Source Code behind all of this - _dropcaps.scss

$dropcaps-lines: 3 !default;
$dropcaps-line-height: 1.6 !default;
$dropcaps-uppercase: true !default;

@mixin dropcaps(
  $lines: $dropcaps-lines,
  $line-height: $dropcaps-line-height,
  $uppercase: $dropcaps-uppercase
) {
  $-margin-right: 0.0962em;
  $mt: (15.6 / 100); 
  $mb: (13.2 / 100);

  $lh: $line-height;
  $n: $lines;
  $h: $n * $lh;

  $-font-size: ($h - ($lh + $mt + $mb) + 1) / (1 - ($mt + $mb));
  $-margin-top: -($mt - ($mt + ($lh - 1) / 2) / $-font-size);
  $-margin-bottom: -($mb);

  &::first-letter {
    float: #{$global-left};
    margin-top: $-margin-top * 1em;
    margin-bottom: $-margin-bottom * 1em;
    margin-#{$global-right}: $-margin-right;
    font-size: $-font-size * 1em;
    line-height: 1;

    @if $uppercase {
      text-transform: uppercase;
    }
  }
}

@mixin foundation-dropcaps {
  .dropcaps {
    @include dropcaps();
  }
}

Generated CSS

.dropcaps {
  line-height: 1.6; 
}

.dropcaps::first-letter {
  float: left;
  margin-top: -0.07301em;
  margin-bottom: -0.132em;
  margin-right: 0.0962em;
  font-size: 5.49438em;
  line-height: 1;
  text-transform: uppercase; 
}

And, the output (Helvetica font)

Mobile output

Desktop output

ncoden · 2017-01-05T22:40:30Z

scss/typography/_helpers.scss

@@ -38,6 +38,29 @@ $subheader-margin-bottom: 0.5rem !default;
 /// @type Number
 $stat-font-size: 2.5rem !default;

+/// @dropcaps
+
+// Line height for all the text within dropcaps, disabling default line height's


/// Comments are used to generate documentation with Sassdoc. For settings, a simple docs is like:

/// Default background color. <-- Formulated like "[This is the] Default backg..." /// @type Color $...-background: $white !default;

I would also advise you to read http://sassdoc.com/annotations/.

ncoden · 2017-01-05T23:33:39Z

scss/typography/_helpers.scss

+$dropcaps-first-letter-line-height: 0.85em !default;
+
+// Dropcaps float
+$dropcaps-first-letter-float: left;


We can only use $global-left without options. There is no case where you would want to have the first letter on the right with a LTR context.

ncoden · 2017-01-05T23:36:18Z

scss/typography/_helpers.scss

+      line-height: $dropcaps-first-letter-line-height;
+      float: $dropcaps-first-letter-float;
+    }
+  }


Please create a Sass component with a mixin:

@mixin dropcaps() { // we have no options for now, unless you want to provide `$dropcaps-lines` or `$dropcaps-space` now. ...code... }

Then use it to create the CSS component:

.dropcaps { @include dropcaps; }

ncoden · 2017-01-05T23:45:54Z

scss/typography/_helpers.scss

+$dropcaps-first-letter-margin-bottom: -0.05em !default;
+
+// Padding Right to the dropcaps first letter to create gap b/w rest of text 
+$dropcaps-first-letter-padding-right: 0.05em !default;


You do not have to provide so much options. Components should be customizable, yes, but it is useless when options are magic numbers that folks cannot easily understand.

I made some search about how dropcaps in CSS are made and found this: http://code.stephenmorley.org/html-and-css/creating-drop-caps/

For now, we can assume these values will not change:

font-size: 5.2em; line-height: .5; margin: 0.192em 0.0962em 0 0;

Later, we can add understable options like:

$dropcaps-lines: Number of lines the height of the first letter should be.

$dropcaps-space: Both vertical and horizontal space between the first letter and the paragraph.
But it would require some maths.

See: https://codepen.io/ncoden/pen/apzXpa

ncoden · 2017-01-05T23:47:39Z

scss/typography/_helpers.scss

+      font-size: $dropcaps-first-letter-font-size;
+      line-height: $dropcaps-first-letter-line-height;
+      float: $dropcaps-first-letter-float;
+    }


You can add: text-transform: uppercase; to prevent problematic letters like q or p.

IamManchanda · 2017-01-06T02:25:32Z

@ncoden .... No issue buddy .... Will try again

IamManchanda · 2017-01-06T05:10:08Z

@ncoden @kball for review on my updated commit as per nicolas review

a.) if changes looks good, please approve and i will squash it up for the merge, or
b.) if more changes are needed, please guide me for the same

Here is the updated output

ncoden · 2017-01-06T05:11:06Z

@IamManchanda Please use semantic names for commit/issues/PRs. It should describe the changes you made (with a complete description for commits), and not what you personally done.

✅ Good:

Remove magic numbers from Dropcaps
Move dropcaps code to a mixin
Fix #xxx - Correct wrong variable name in Dropcaps
Remove rain and add a sun

❌ Bad:

Update Dropcaps
Apply changes asked by @someone
I fixed #xxx
Here some changes, btw beautiful weather today, isn't it ?

IamManchanda · 2017-01-06T05:15:21Z

so is there any git command to update my commit message ? @ncoden

IamManchanda · 2017-01-06T05:23:33Z

done @ncoden .... i have updated the commit message .... did it myself .... thanks to some googling and that git rebase practice at my first PR by kevin sir

ncoden · 2017-01-06T05:15:32Z

scss/typography/_helpers.scss

+@mixin foundation-dropcaps() { 
+  font-size: $dropcaps-font-size;
+  line-height: $dropcaps-line-height;
+  vertical-align: $dropcaps-vertical-align;


vertical-align is useless when we use float, because the element is "out of the flow" and its position cannot be compared with the others component's one.

ohk but i found this in your codepen so used it 😈

Sorry about that 😄

ncoden · 2017-01-06T05:17:24Z

scss/typography/_helpers.scss

+  text-transform: $dropcaps-text-transform;
+  margin: $dropcaps-margin;
+  float: #{$global-left};
+}


Please use the Specific property order.

ncoden · 2017-01-06T05:18:28Z

scss/typography/_helpers.scss

+
+  // Use to create an initial aka dropcap
+  .dropcaps{
+    line-height: 1.5; // Disabling default line height of an element


@ncoden i did that to let it look similar on proportion to rest of the text ... no matter what the element is

currently by default its,
h1 to h6 => 1.4
body => 1.5
p => 1.6

But if you dont want.... no issue i will remove it @ncoden

No, keep it.

So to expand on this & the result... this means that @include dropcaps or adding the .dropcaps class will change the line height when applied to tags like p or h1... ie my leading paragraph where I want to include a dropcaps will look fundamentally different than my other paragraphs...

And further, this is not accessible to change via a var or mixin parameter.

I'm not sure this is the right solution. What if we made this a parameter to the mixin and computed the :first-letter lineheight from it?

ncoden · 2017-01-06T05:19:26Z

scss/typography/_helpers.scss

+    line-height: 1.5; // Disabling default line height of an element
+    &:first-letter {
+      @include foundation-dropcaps;
+    }


The "dropcaps" component is the full paragraph. @mixin foundation-dropcaps should contain &:first-letter {...}.

ncoden · 2017-01-06T05:19:43Z

scss/typography/_helpers.scss

 }
+
+
+


Empty lines here

ncoden · 2017-01-06T05:23:27Z

scss/typography/_helpers.scss

+
+/// Deafult margin for dropcaps
+/// @type Numbers
+$dropcaps-margin: 0.192em 0.0962em 0 0 !default;


Like I said before, this is useless to provide it as a setting for now, because it is complex numbers the user cannot modify properly. We can provide a $dropcaps-margin option only if $dropcaps-margin: 0 gives the render we would expect by its name: no margins between the letter and the paragraph.

Please remove these settings and use private variables inside @mixin foundation-dropcaps.

ncoden · 2017-01-06T05:26:41Z

scss/typography/_helpers.scss

+
+/// Default text transform for dropcaps
+/// @type String
+$dropcaps-text-transform: uppercase !default;


The only text-transform values that could make sense in this component are:

inherit

uppercase

So we should rather provide a $dropcaps-uppercase: true Boolean here.

ncoden · 2017-01-06T05:28:39Z

scss/typography/_helpers.scss

+
+/// Default line height for dropcaps
+/// @type Number
+$dropcaps-line-height: 0.5 !default;


For $dropcaps-font-size and $dropcaps-line-height: private variables, see $dropcaps-margin below.

ncoden · 2017-01-06T05:33:04Z

Try to use title for commits of less than 80 characters, and use the description for complete information.

Sorry for all these remarks, I am very picky just for you so you can improve youself 😄 .

IamManchanda · 2017-01-06T05:35:13Z

No its ohkkk .... i dont mind .... these remarks is surely helping me out
but will do it later in the day as gonna be busy now

IamManchanda · 2017-01-06T14:21:11Z

Confused about private variables ? @ncoden @kball
Rest is done, so please explain

Are you saying me to use it like this below or something else
{{ i mean for margin, font-size and line-height }}

@mixin foundation-dropcaps() { 
  line-height: 1.5; // Disabling default line height of an element
    &:first-letter {
      float: #{$global-left};
      margin: 0.192em 0.0962em 0 0;
      font-size: 5.2em;
      line-height: .5;

      @if $dropcaps-uppercase {
        text-transform: uppercase;
      }
    }
}

ncoden · 2017-01-06T14:25:05Z

/// Config variable
$config-variable: ...;

/// Component
@mixin component($parameter: ...) {
  $private-variable: ...;
}

A variable inside a component, that cannot be modified by user, separated from properties only for clarity.

IamManchanda · 2017-01-06T14:35:29Z

Oh You mean a global variable @ncoden

Are you talking about this ?

@mixin dropcaps($dropcaps-margin, $dropcaps-font-size, $dropcaps-line-height) { 
  line-height: 1.5; // Disabling default line height of an element
    &:first-letter {
      float: #{$global-left};
      margin: $dropcaps-margin;
      font-size: $dropcaps-font-size;
      line-height: $dropcaps-line-height;

      @if $dropcaps-uppercase {
        text-transform: uppercase;
      }
    }
}

& the CSS component

.dropcaps{
   @include dropcaps(0.192em 0.0962em 0 0, 5.2em, .5);
}

Update after below review: changed foundation-dropcaps to dropcaps

ncoden · 2017-01-06T14:38:52Z

scss/typography/_helpers.scss

+/// @type Numbers
+$dropcaps-margin: 0.192em 0.0962em 0 0 !default;
+
+@mixin foundation-dropcaps() { 


foundation-* mixins are only used to generate default styles. For now, component mixins does not have a prefix (but I agree they should have one).
So please use just dropcaps.

ohk no issue for this one

Infact changed , But tell me about the above one @ncoden

IamManchanda · 2017-01-06T14:48:19Z

awaiting reply, @ncoden ... for the above comment

ncoden · 2017-01-06T14:49:46Z

No, I mean a variable inside the mixin the user cannot modify:
-> comment are for you and should not be kept in the code.

// Dropcaps component
@mixin dropcaps(
  // -> Do not use global settings directly but via parameters, so they can be modified locally.
  $uppercase: $dropcaps-uppercase
) {
  // { comment to explain where these values come from }
  // ...
  $-margin: 0.192em 0.0962em 0 0;
  $-font-size: 5.2em;
  $-line-height: .5;

  line-height: 1.5; // Disabling default line height of an element

  &:first-letter {
    float: #{$global-left};
    margin: $-margin;
    font-size: $-font-size;
    line-height: $-line-height;

    @if $dropcaps-uppercase {
      text-transform: uppercase;
    }
  }
}

...

// Generate default styles
.dropcaps {
   @include dropcaps();
}

So later you can do:

.my-own-dropcaps {
  @include dropcaps($uppercase: false);
}

But it would make no sense to do something like this:

.my-own-dropcaps {
  // -> Do not use
  @include dropcaps($dropcaps-margin: 0 0 1em 0);
}

... Because 0 0 1em 0 or any other value cannot be provided without having to understand the way the component works internally.

ncoden · 2017-01-06T14:55:01Z

@IamManchanda Don't worry, I receive notifications ;)

IamManchanda · 2017-01-06T15:17:27Z

Check this out now nico bro

/// Dropcaps component
@mixin dropcaps($uppercase: $dropcaps-uppercase) {
  // Default margin from top and right to let it properly aligned
  // and have a tiny horizontal space with rest of the text 
  $-margin: 0.192em 0.0962em 0 0; 
  $-font-size: 5.2em; // Default font size for dropcaps
  $-line-height: .5; // Default line height for dropcaps 

  line-height: 1.5; // Disabling default line height of an element

  &:first-letter {
    float: #{$global-left};
    margin: $-margin;
    font-size: $-font-size;
    line-height: $-line-height;

    @if $dropcaps-uppercase {
      text-transform: uppercase;
    }
  }
}

But, i must say ..... from all of this ..... neither output or css is changing
Pretty much same ( except that vertical-align: baseline 😜 )
Only SCSS and logic is changing .... lol 😈

But hey,
These type of things we never think about @ my job
and i feel that is a very great learning curve me
and thanks to you who are helping me out

IamManchanda · 2017-01-06T15:24:19Z

and hey how do you get these colored syntax ? @ncoden

Update: No Thanks, i found it out 😉

ncoden · 2017-01-06T16:07:50Z

Please write commit instead of writing text in comment, so I can review it line per line.

And these $- variables are not parameters, they are internal values, so your comment should indicate where they come from : from here for Helvetica.

ncoden

This is almost good :)

Now I have two questions for @kball:

What do you think ?
Should we move @mixin-dropcaps to its own file like @mixin-header ?

ncoden · 2017-01-06T18:18:17Z

scss/typography/_helpers.scss

-
-
-
+}


EOL at the end of the file pls.

@ncoden did not understand ... do you mean to give one line space at the end ?

Yes. Always let one end-of-line (not an empty line) at the end of files. If you use an editor like Sublime Text or Atom, there is plugin to do that automatically

ncoden · 2017-01-06T18:26:04Z

scss/typography/_helpers.scss

+$dropcaps-uppercase: true !default;
+
+/// Dropcaps component
+@mixin dropcaps($uppercase: $dropcaps-uppercase) {


/// Dropcaps component /// @param { Boolean } $uppercase [$dropcaps-uppercase] If `true`, makes dropcaps uppercase. @mixin dropcaps( $uppercase: $dropcaps-uppercase ) {

Add comment for parameter

Show one parameter per line

ncoden · 2017-01-06T18:27:19Z

scss/typography/_helpers.scss

+/// Dropcaps component
+@mixin dropcaps($uppercase: $dropcaps-uppercase) {
+  // Default margin (Arial/Helvetica) to let it properly aligned from the top on the 
+  // first line beside it and have a tiny space between them through the right


// See: http://code.stephenmorley.org/html-and-css/creating-drop-caps/

@ncoden - If you are talking about the comment, i have used it from there only and my english isn't great. so would request you to give me the content for it and i will add ... Pleaseee ?

I mean: just add the link below your comment.

ncoden · 2017-01-06T18:28:42Z

scss/typography/_helpers.scss

+    font-size: $-font-size;
+    line-height: $-line-height;
+
+    @if $dropcaps-uppercase {


@if $uppercase {

(the parameter, not the global setting)

ohk sure understood

ncoden · 2017-01-06T18:33:15Z

scss/typography/_helpers.scss

+@mixin dropcaps($uppercase: $dropcaps-uppercase) {
+  // Default margin (Arial/Helvetica) to let it properly aligned from the top on the 
+  // first line beside it and have a tiny space between them through the right
+  $-margin: 0.192em 0.0962em 0 0; 


Hmm... Just seen it is not bidi-compliant (read in RTL and LTR).

We can use this instead:

$-margin-top: 0.192em; $-margin-right: 0.0962em; ... margin-top: $-margin-top; margin-#{$global-right}: $-margin-right;

Hmmnnn.... you are right! .... oh i mean left ... oh sorry right 😈

IamManchanda · 2017-01-06T19:15:21Z

hope @ncoden now its ohk .... ??

ncoden

@kball Waiting for your opinion for the questions above :)

ncoden · 2017-01-06T19:16:00Z

scss/typography/_helpers.scss

No empty line here

IamManchanda · 2017-01-06T19:23:36Z

shall i squash it to one now ? @ncoden @kball

pheww....... 😓 😅 😰

ncoden · 2017-01-06T19:39:57Z

I requested you a lot of change, I know 😄. But I think I asked you everything that could be asked, so your next PR will be perfect !

It makes me think we should add a full guide for Sass and contribution in docs. We talked about it before with @kball.

About the squatch, I would prefer to do it in merging, so the commit history in this PR will be preserved. It's the same for rebase. Before I recommended it but now I think it should be avoided. Again, this require more discussion about our workflow. I will add this question to #9576.

IamManchanda · 2017-01-06T19:43:26Z

Ohk no squash then, even i thought that no squash will preserve the commit history !
& i leave docs section to you guys

ncoden · 2017-01-06T19:46:01Z

Ah, yes ! I forgot the docs !
I'll take care of it later :)

IamManchanda · 2017-01-06T19:56:42Z

I requested you a lot of change, I know

Yup i thought that few more reviews, comments and commit, and this would have raced up to most commented pull request pretty quickly 😄

IamManchanda · 2017-01-12T21:34:48Z

@kball : The development phase is over now ...
Can we have final review Kevin sir ??

kball

There's a lot of magic numbers, some complex formulas, and short, unintuitive variable names. Can we provide references for where the numbers and formulas are coming from? And potentially name the variables in a way that someone looking it this has a chance of understanding what they are?

kball · 2017-01-12T21:38:27Z

scss/typography/_dropcaps.scss

+  $-margin-right: 0.0962em;
+
+  // Font metrics (for Helvetica Neue)
+  $mt: (15.6 / 100); // Distance between Ascent and Top


Where do these magic numbers come from?

Measure by yourself: https://codepen.io/ncoden/pen/mRJvEg ;)
I agree there is certainly a way to get the exact metrics of fonts. We should also declare them in Sass as a ~standard map in settings.

kball · 2017-01-12T21:38:56Z

scss/typography/_dropcaps.scss

+  $n: $lines;
+  $h: $n * $lh;
+
+  $-font-size: ($h - ($lh + $mt + $mb) + 1) / (1 - ($mt + $mb));


Is there a reference for this formula?

Or the one below it?

cc / @ncoden

Yes. I'm working on it.

kball · 2017-01-12T21:39:56Z

scss/typography/_dropcaps.scss

+) {
+  // Default margin right (Arial/Helvetica) for having a tiny space between them through the right,
+  // See: http://code.stephenmorley.org/html-and-css/creating-drop-caps
+  $-margin-right: 0.0962em;


If this is specific to Arial/Helvetica, what happens if someone is not using those?

See the docs:

The initial letter has the best alignment with the paragraph lines for standard serif and sans-serif fonts like Helvetica or Times New Roman. The render may differ for fonts with different metrics.

However, I have some idea to generate his value dynamically, to try to have the same space on the right (or left for LRT) of the letter than we have under it.

I Have tested with many web fonts like Roboto, Open sans, Nato Sans, Ubuntu and oxygen and works well ! Infact i also tested with monospace and it works well there too. So there is no such font issue as per my best of knowledge and for sure this is not breaking #9596 development

Although i would also arque that these below private variables should be there as configuration variables so that user's can change it to there font needs !

- $-margin-right - $mt - $mb

Thoughts ?

@IamManchanda Agreed. These values can "match" with the most common fonts, but these are still values for Helvetica Neue and there is no guarantee the render will be still good with other fonts.

However, please warn when you are working on an issue

So are you doing this or shall i do this ?

I am working on it.

ohk will be waiting bro !

RamanCool · 2017-01-13T16:53:32Z

I didn't knew that foundation team members works so hard and like this for every single feature... Liked it very much, @IamManchanda @ncoden.

ncoden · 2017-01-13T16:59:51Z

@RamanCool We do not. I have a curse which force me to review and work on a pull request forever until it is perfectly perfect.

IamManchanda · 2017-01-14T19:37:38Z

Any update Nicolas ?

ncoden · 2017-01-14T19:42:43Z

I lost the whole day to learn how font metrics are provided in standard formats. And it appear that, even today, there is not a standard way to interpret these values. So we will have to provide a map of datas (ascender, descender, capital height) we measured ourself !

I said I am working on this. Do not worry 😄 .

IamManchanda · 2017-01-18T13:24:08Z

sorry to pinch you again but any updates bro ? 😄

ncoden · 2017-01-18T13:33:14Z

I'm blocked on: https://codepen.io/ncoden/pen/mRJvEg, and waiting answers from people who know W3C better than me.

The workaround will be to use our own font metrics (like we are currently) instead of standard OS/2 metrics.

IamManchanda · 2017-01-18T13:41:13Z

How about you opening a issue request for the same ⬆️ with reference to this pr and codepen, you might get answers or how about posting it on stack overflow?

ncoden · 2017-01-18T13:42:54Z

I will :)

IamManchanda · 2017-01-24T15:03:22Z

So did you got the answers @ncoden ?

IamManchanda · 2017-03-14T18:59:10Z

@ncoden any updates and what about including feature queries within it!

@supports (initial-letter: 4) or (-webkit-initial-letter: 4) {
  .dropcaps::first-letter {
     -webkit-initial-letter: 4;
     initial-letter: 4;
}

=> https://hacks.mozilla.org/2016/08/using-feature-queries-in-css/

IamManchanda · 2017-06-04T07:00:08Z

As nicolas has decided to take a break ...
Would anyone of you @zurb/yetinauts would like to chime in and help me complete this PR ??

Secondly @ncoden
Can you please give 15-20min to tell us in brief the development you had in discussions that you had in stackoverflow etc so that we can get it across the line!

DanielRuf · 2018-02-19T19:55:42Z

I'm blocked on: https://codepen.io/ncoden/pen/mRJvEg, and waiting answers from people who know W3C better than me.

The workaround will be to use our own font metrics (like we are currently) instead of standard OS/2 metrics.

Not sure if I understand correctly. We had typography in school and this is right what you see. Think about a printer using single letters. They all need to be aligned on the x line (the baseline). The space for the serif parts always is there. It is often just not used and is the leading between the lines (the white / grey factor and the space between them).

The W3C spec says

Note that certain glyphs may bleed outside their em squares.

Which is totally fine and expected. We can not redefine the bleedbox of a provided font which uses serif parts

http://typedia.com/learn/only/anatomy-of-a-typeface/

ncoden · 2018-02-19T19:59:05Z

@DanielRuf The issue you replied to is resolved. I was understanding the W3C reference correctly but compared it with wrong measures and calculations --'

DanielRuf · 2018-02-19T20:01:28Z

@DanielRuf The issue you replied to is resolved. I was understanding the W3C reference correctly but compared it with wrong measures and calculations --'

Oh, was not aware of it as this PR is still open.

DanielRuf · 2018-02-19T20:02:50Z

Or are all other questions answered and this can be probably merged in one of the planned milestones?

ncoden · 2018-02-19T20:04:38Z

Oh, was not aware of it as this PR is still open.

It is still open because I have to go back into the PR, clean the code, add documentation and resolve the last bugs. And this require me to understand what I did there (or remind it).

DanielRuf · 2018-02-19T20:09:55Z

Understood =)

kball · 2019-08-12T22:07:19Z

Given this was pending work from @ncoden and AFAIK he is no longer involved, I'm going to close this.

ncoden suggested changes Jan 5, 2017

View reviewed changes

ncoden reviewed Jan 5, 2017

View reviewed changes

IamManchanda force-pushed the feature/css-dropcaps branch from 2b545c1 to f2371d3 Compare January 6, 2017 05:22

ncoden suggested changes Jan 6, 2017

View reviewed changes

ncoden reviewed Jan 6, 2017

View reviewed changes

ncoden approved these changes Jan 6, 2017

View reviewed changes

scss/typography/_helpers.scss

Copy link

Contributor

ncoden Jan 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No empty line here

kball suggested changes Jan 12, 2017

View reviewed changes

added copyright content within _dropcaps.scss

a65e2d9

Adding dropcaps component/helper to kitchen sink

ea6c2ee

IamManchanda mentioned this pull request Feb 3, 2017

[Advancement] Prototype/sepration from core #9738

Closed

27 tasks

rafibomb added the scss label Feb 3, 2017

IamManchanda assigned ncoden Apr 21, 2017

IamManchanda unassigned ncoden Jun 4, 2017

IamManchanda changed the title ~~Feature #9592: CSS Dropcaps, v6.4~~ Feature #9592: CSS Dropcaps, v6 Jun 4, 2017

IamManchanda added this to the 6.5 milestone Jun 4, 2017

IamManchanda mentioned this pull request Jan 28, 2018

Feature Request: CSS Dropcaps #9592

Closed

kball closed this Aug 12, 2019

Feature #9592: CSS Dropcaps, v6 #9609

Feature #9592: CSS Dropcaps, v6 #9609

Conversation

IamManchanda commented Jan 5, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ncoden Jan 5, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

IamManchanda commented Jan 6, 2017

IamManchanda commented Jan 6, 2017

ncoden commented Jan 6, 2017 • edited

IamManchanda commented Jan 6, 2017 • edited

IamManchanda commented Jan 6, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ncoden commented Jan 6, 2017

IamManchanda commented Jan 6, 2017 • edited

IamManchanda commented Jan 6, 2017 • edited

ncoden commented Jan 6, 2017 • edited

IamManchanda commented Jan 6, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

IamManchanda Jan 6, 2017 • edited

Choose a reason for hiding this comment

IamManchanda commented Jan 6, 2017

ncoden commented Jan 6, 2017 • edited

ncoden commented Jan 6, 2017

IamManchanda commented Jan 6, 2017 • edited

IamManchanda commented Jan 6, 2017 • edited

ncoden commented Jan 6, 2017

ncoden left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

IamManchanda Jan 6, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

IamManchanda Jan 6, 2017 • edited

Choose a reason for hiding this comment

IamManchanda commented Jan 6, 2017

ncoden left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

IamManchanda commented Jan 6, 2017

ncoden commented Jan 6, 2017

IamManchanda commented Jan 6, 2017 • edited

ncoden commented Jan 6, 2017

IamManchanda commented Jan 6, 2017

IamManchanda commented Jan 12, 2017

kball left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ncoden Jan 13, 2017 • edited

Choose a reason for hiding this comment

IamManchanda Jan 13, 2017 • edited

IamManchanda commented Jan 5, 2017 •

edited

ncoden Jan 5, 2017 •

edited

ncoden commented Jan 6, 2017 •

edited

IamManchanda commented Jan 6, 2017 •

edited

IamManchanda commented Jan 6, 2017 •

edited

IamManchanda commented Jan 6, 2017 •

edited

IamManchanda commented Jan 6, 2017 •

edited

ncoden commented Jan 6, 2017 •

edited

IamManchanda commented Jan 6, 2017 •

edited

IamManchanda Jan 6, 2017 •

edited

ncoden commented Jan 6, 2017 •

edited

IamManchanda commented Jan 6, 2017 •

edited

IamManchanda commented Jan 6, 2017 •

edited

IamManchanda Jan 6, 2017 •

edited

IamManchanda Jan 6, 2017 •

edited

IamManchanda commented Jan 6, 2017 •

edited

ncoden Jan 13, 2017 •

edited

IamManchanda Jan 13, 2017 •

edited

IamManchanda Jan 13, 2017 •

edited

ncoden commented Jan 13, 2017 •

edited

IamManchanda commented Jan 14, 2017 •

edited

IamManchanda commented Jan 18, 2017 •

edited

ncoden commented Jan 18, 2017 •

edited

IamManchanda commented Jan 18, 2017 •

edited

IamManchanda commented Jan 24, 2017 •

edited

IamManchanda commented Mar 14, 2017 •

edited

DanielRuf commented Feb 19, 2018 •

edited

DanielRuf commented Feb 19, 2018 •

edited

ncoden commented Feb 19, 2018 •

edited