New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getLocale functions #760

Open
KamasamaK opened this Issue Dec 19, 2017 · 8 comments

Comments

Projects
None yet
3 participants
@KamasamaK
Contributor

KamasamaK commented Dec 19, 2017

I have been unable to find anything on the functions getLocaleCountry and getLocaleLanguage added in #581. All of the engine links are for getLocaleDisplayName and the examples do not work on TryCF for any of the engines.

@KamasamaK KamasamaK changed the title from getLocaleCountry to getLocale functions Dec 19, 2017

@pfreitag

This comment has been minimized.

Show comment
Hide comment
@pfreitag

pfreitag Dec 21, 2017

Member

@shaedrich - looks like you added those, do you have any more info?

Member

pfreitag commented Dec 21, 2017

@shaedrich - looks like you added those, do you have any more info?

@shaedrich

This comment has been minimized.

Show comment
Hide comment
@shaedrich

shaedrich Dec 21, 2017

Contributor

You can find information about it in the Lucee update docs. When I added them, they seemed to work as far as I remember.

Contributor

shaedrich commented Dec 21, 2017

You can find information about it in the Lucee update docs. When I added them, they seemed to work as far as I remember.

@KamasamaK

This comment has been minimized.

Show comment
Hide comment
@KamasamaK

KamasamaK May 16, 2018

Contributor

@shaedrich Can you please verify which version of Lucee that you tried that supports these functions? None of the engines hosted on TryCF support these functions.

Contributor

KamasamaK commented May 16, 2018

@shaedrich Can you please verify which version of Lucee that you tried that supports these functions? None of the engines hosted on TryCF support these functions.

@shaedrich

This comment has been minimized.

Show comment
Hide comment
@shaedrich

shaedrich May 16, 2018

Contributor

As stated in the update docs, they were added and removed in the same version only for internal proposes. So they do not work in any version. Don't ask me for reasons, ask them :D

Contributor

shaedrich commented May 16, 2018

As stated in the update docs, they were added and removed in the same version only for internal proposes. So they do not work in any version. Don't ask me for reasons, ask them :D

@KamasamaK

This comment has been minimized.

Show comment
Hide comment
@KamasamaK

KamasamaK May 16, 2018

Contributor

I didn't see anything in the update docs stating they were added and removed in the same version. They were included in a list with no further information on them other than that they were deprecated (which is not the same as being removed). I thought you said you had gotten them to work. That doesn't really make much sense if they were added and removed in the same version, but even if that's the case my previous question regarding which version exactly still needs an answer.

Otherwise, is it even worth it to keep them documented? The current documentation seems useless as it is -- no useful external references, no way to test, inaccurate engines information.

Contributor

KamasamaK commented May 16, 2018

I didn't see anything in the update docs stating they were added and removed in the same version. They were included in a list with no further information on them other than that they were deprecated (which is not the same as being removed). I thought you said you had gotten them to work. That doesn't really make much sense if they were added and removed in the same version, but even if that's the case my previous question regarding which version exactly still needs an answer.

Otherwise, is it even worth it to keep them documented? The current documentation seems useless as it is -- no useful external references, no way to test, inaccurate engines information.

@shaedrich

This comment has been minimized.

Show comment
Hide comment
@shaedrich

shaedrich May 16, 2018

Contributor

Oh, sorry. You're right. They are deprecated. That's all I know. We both read the document. That's all we have.
The version is written in the update docs and on cfdocs as well: Lucee 5. Why is that engine information inaccurate. Sorry but I don't see your point.

The question of keeping it documented may be addressed to @pfreitag. But for me it doesn't really matter matter if we keep it. I just tried to get rid of the open issue where the update docs were linked.

Contributor

shaedrich commented May 16, 2018

Oh, sorry. You're right. They are deprecated. That's all I know. We both read the document. That's all we have.
The version is written in the update docs and on cfdocs as well: Lucee 5. Why is that engine information inaccurate. Sorry but I don't see your point.

The question of keeping it documented may be addressed to @pfreitag. But for me it doesn't really matter matter if we keep it. I just tried to get rid of the open issue where the update docs were linked.

@KamasamaK

This comment has been minimized.

Show comment
Hide comment
@KamasamaK

KamasamaK May 16, 2018

Contributor

@shaedrich The engines is inaccurate because it says that all 4 of the engines support it and have no indication of when it was added or removed from any engine, when we now know that if it was ever added to any that it must have been removed since it does not work in any recent versions of those engines. It is also inaccurate because the docs links are for a different function that make no mention of the relevant function.

If the only documentation of its existence is one sentence in a Lucee update document, then that's pretty scarce. I don't know the context of the document since Lucee has many versions within 5, so it might only refer to 5.0 or it might be updated for point releases. The version prior to 5.0 is 4.5, which does not support those functions on TryCF either. Regardless, there would be no reason to assume just from that sentence that any other engine supports the functions. I would just ask that when adding a function to exercise due diligence by confirming these things.

Contributor

KamasamaK commented May 16, 2018

@shaedrich The engines is inaccurate because it says that all 4 of the engines support it and have no indication of when it was added or removed from any engine, when we now know that if it was ever added to any that it must have been removed since it does not work in any recent versions of those engines. It is also inaccurate because the docs links are for a different function that make no mention of the relevant function.

If the only documentation of its existence is one sentence in a Lucee update document, then that's pretty scarce. I don't know the context of the document since Lucee has many versions within 5, so it might only refer to 5.0 or it might be updated for point releases. The version prior to 5.0 is 4.5, which does not support those functions on TryCF either. Regardless, there would be no reason to assume just from that sentence that any other engine supports the functions. I would just ask that when adding a function to exercise due diligence by confirming these things.

@shaedrich

This comment has been minimized.

Show comment
Hide comment
@shaedrich

shaedrich May 16, 2018

Contributor

It was added in one of the 5.* versions. But you're right: ACF and BD did and do not at any time, that's my fault. But many functions only have Lucee5 for engine version.

Contributor

shaedrich commented May 16, 2018

It was added in one of the 5.* versions. But you're right: ACF and BD did and do not at any time, that's my fault. But many functions only have Lucee5 for engine version.

shaedrich added a commit to shaedrich/cfdocs that referenced this issue May 16, 2018

Fix up wrong information
- Neither Open BD nor ACF ever supported that function
- Update docs state that function was added and deprecated in that version but gives not much more information

For discussion see: foundeo#760

shaedrich added a commit to shaedrich/cfdocs that referenced this issue May 16, 2018

Fix up wrong information
- Neither Open BD nor ACF ever supported that function
- Update docs state that function was added and deprecated in that version but gives not much more information

For discussion see: foundeo#760
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment