New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples area #864

Closed
KrunchMuffin opened this Issue Jun 7, 2018 · 11 comments

Comments

Projects
None yet
3 participants
@KrunchMuffin
Contributor

KrunchMuffin commented Jun 7, 2018

I just wanted to voice my opinion about the examples area.

Having all the syntax closed by default is inconvenient especially when all the headings are the same with no clue as to what it is going to uncover.
Also only allowed to have one open at a time is even more so. Now you can't compare one over another over another.

image

@shaedrich

This comment has been minimized.

Show comment
Hide comment
@shaedrich

shaedrich Jun 7, 2018

Contributor

Got point!

Every contributor is told to not use a heading like this. That didn't look good before either.

But it would be good to

  1. Open the first one by default
  2. Don't close panel when another one is opened
Contributor

shaedrich commented Jun 7, 2018

Got point!

Every contributor is told to not use a heading like this. That didn't look good before either.

But it would be good to

  1. Open the first one by default
  2. Don't close panel when another one is opened
@KrunchMuffin

This comment has been minimized.

Show comment
Hide comment
@KrunchMuffin

KrunchMuffin Jun 7, 2018

Contributor
Contributor

KrunchMuffin commented Jun 7, 2018

@shaedrich

This comment has been minimized.

Show comment
Hide comment
@shaedrich

shaedrich Jun 7, 2018

Contributor

Do you just want to expand/collapse all examples back and forth?

Contributor

shaedrich commented Jun 7, 2018

Do you just want to expand/collapse all examples back and forth?

@KrunchMuffin

This comment has been minimized.

Show comment
Hide comment
@KrunchMuffin

KrunchMuffin Jun 7, 2018

Contributor
Contributor

KrunchMuffin commented Jun 7, 2018

@pfreitag

This comment has been minimized.

Show comment
Hide comment
@pfreitag

pfreitag Jun 7, 2018

Member

Thanks for bringing this up @KrunchMuffin

I agree - I think we should open all by default unless there are more than X examples. When there are more than X examples I still think it is useful to open them by default but then maybe just have a way to collapse expand all.

Member

pfreitag commented Jun 7, 2018

Thanks for bringing this up @KrunchMuffin

I agree - I think we should open all by default unless there are more than X examples. When there are more than X examples I still think it is useful to open them by default but then maybe just have a way to collapse expand all.

@KrunchMuffin

This comment has been minimized.

Show comment
Hide comment
@KrunchMuffin

KrunchMuffin Jun 7, 2018

Contributor
Contributor

KrunchMuffin commented Jun 7, 2018

@shaedrich

This comment has been minimized.

Show comment
Hide comment
@shaedrich

shaedrich Jun 7, 2018

Contributor

So what do we consider as X? 5? 10?

Contributor

shaedrich commented Jun 7, 2018

So what do we consider as X? 5? 10?

@KrunchMuffin

This comment has been minimized.

Show comment
Hide comment
@KrunchMuffin

KrunchMuffin Jun 8, 2018

Contributor

25 😊

Contributor

KrunchMuffin commented Jun 8, 2018

25 😊

@shaedrich

This comment has been minimized.

Show comment
Hide comment
@shaedrich

shaedrich Jun 8, 2018

Contributor

That's much. How big is your screen, dude? 😂

Contributor

shaedrich commented Jun 8, 2018

That's much. How big is your screen, dude? 😂

@KrunchMuffin

This comment has been minimized.

Show comment
Hide comment
@KrunchMuffin

KrunchMuffin Jun 8, 2018

Contributor
Contributor

KrunchMuffin commented Jun 8, 2018

@shaedrich

This comment has been minimized.

Show comment
Hide comment
@shaedrich

shaedrich Jun 8, 2018

Contributor

I got it that you want them all open. Then 42 would have been pure invention as well^^

We already agree to make a expand/collapse button. But as @pfreitag pointed out it would be too much to initially open all if they exceed a specific amount.

Contributor

shaedrich commented Jun 8, 2018

I got it that you want them all open. Then 42 would have been pure invention as well^^

We already agree to make a expand/collapse button. But as @pfreitag pointed out it would be too much to initially open all if they exceed a specific amount.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment