New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples for collectionSome() are for collectionEvery() #886

Closed
SebastianZ opened this Issue Jul 12, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@SebastianZ

SebastianZ commented Jul 12, 2018

The examples for collectionSome() are obviously copied over from collectionEvery().

They need to be changed to include collectionSome().

Sebastian

@shaedrich

This comment has been minimized.

Show comment
Hide comment
@shaedrich

shaedrich Jul 12, 2018

Contributor

Just replace collectionEvery() with collectionSome(). It's good to have similar examples for similar methods, but the way it is now, does not make sense — you're right.

Contributor

shaedrich commented Jul 12, 2018

Just replace collectionEvery() with collectionSome(). It's good to have similar examples for similar methods, but the way it is now, does not make sense — you're right.

@shaedrich

This comment has been minimized.

Show comment
Hide comment
@shaedrich

shaedrich Jul 16, 2018

Contributor

Same happened to listFilter() and arrayFilter()

Contributor

shaedrich commented Jul 16, 2018

Same happened to listFilter() and arrayFilter()

pfreitag added a commit that referenced this issue Oct 12, 2018

Merge pull request #953 from ckarras11/issue/#886-collectionSome
Changed collectionEvery to collectionSome
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment