Skip to content

fix: imports regex fallback #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2024
Merged

fix: imports regex fallback #225

merged 1 commit into from
Nov 20, 2024

Conversation

@klkvr
Copy link
Member

@klkvr klkvr commented Nov 20, 2024

smol typo, should close foundry-rs/foundry#9365

DaniPopes
DaniPopes approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

@klkvr klkvr changed the title fix imports regex fallback fix: imports regex fallback Nov 20, 2024
@klkvr klkvr merged commit da52aa7 into main Nov 20, 2024
15 checks passed
@klkvr klkvr deleted the klkvr/readd-imports branch November 20, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

breaking(nightly): Ambiguous import. Multiple matching files found inside base path and/or include paths

3 participants

@klkvr @DaniPopes