Skip to content

fix: assume not precompiles for optimism sepolia #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 22, 2025
Merged

fix: assume not precompiles for optimism sepolia #750

merged 5 commits into from
Oct 22, 2025

Conversation

@grandizzy
Copy link
Contributor

@grandizzy grandizzy commented Oct 22, 2025 •
edited
Loading

  • baf6ba0 apply precompiles checks for optimism sepolia, fixes testFuzz_AssumeNotPrecompile test
     [FAIL: assertion failed; counterexample: calldata=0x9d624fa10000000000000000000000004200000000000000000000000000000000000000 args=[0x4200000000000000000000000000000000000000]] testFuzz_AssumeNotPrecompile(address) (runs: 2, μ: 5868184, ~: 5868184)

Others - fix CI:

0xrusowsky
0xrusowsky previously approved these changes Oct 22, 2025
View reviewed changes
@grandizzy grandizzy marked this pull request as draft October 22, 2025 07:50
@grandizzy grandizzy force-pushed the fix-assume-not-precompile branch from 667cf88 to 966dad4 Compare October 22, 2025 08:11
@grandizzy grandizzy force-pushed the fix-assume-not-precompile branch from 966dad4 to bcf8ea2 Compare October 22, 2025 08:13
@grandizzy grandizzy requested a review from 0xrusowsky October 22, 2025 08:16
@grandizzy grandizzy marked this pull request as ready for review October 22, 2025 08:16
@grandizzy grandizzy mentioned this pull request Oct 22, 2025
Closed
zerosnacks
zerosnacks approved these changes Oct 22, 2025
View reviewed changes
Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@grandizzy grandizzy merged commit a6d71da into foundry-rs:master Oct 22, 2025
25 checks passed
@grandizzy grandizzy deleted the fix-assume-not-precompile branch October 22, 2025 09:52
@grandizzy grandizzy self-assigned this Oct 27, 2025
@grandizzy grandizzy mentioned this pull request Oct 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xrusowsky 0xrusowsky 0xrusowsky approved these changes

@zerosnacks zerosnacks zerosnacks approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees

@grandizzy grandizzy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@grandizzy @0xrusowsky @zerosnacks