Skip to content

fix(chisel): don't panic on bad pc/memory #12674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2025
+11 −5
Merged

fix(chisel): don't panic on bad pc/memory #12674

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions crates/chisel/src/executor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,11 +152,17 @@ impl SessionSource {

// the file compiled correctly, thus the last stack item must be the memory offset of
// the `bytes memory inspectoor` value
let mut offset = stack.last().unwrap().to::<usize>();
let mem_offset = &memory[offset..offset + 32];
let len = U256::try_from_be_slice(mem_offset).unwrap().to::<usize>();
offset += 32;
let data = &memory[offset..offset + len];
let data = (|| -> Option<_> {
let mut offset: usize = stack.last()?.try_into().ok()?;
debug!("inspect memory @ {offset}: {}", hex::encode(memory));
let mem_offset = memory.get(offset..offset + 32)?;
let len: usize = U256::try_from_be_slice(mem_offset)?.try_into().ok()?;
offset += 32;
memory.get(offset..offset + len)
})();
let Some(data) = data else {
eyre::bail!("Failed to inspect last expression: could not retrieve data from memory")
};
let token = ty.abi_decode(data).wrap_err("Could not decode inspected values")?;
let c = if should_continue(contract_expr) {
ControlFlow::Continue(())
Expand Down
Loading