feat(tempo): resolve live session signers#14883
Merged
Merged
Conversation
0xKarl98
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mablr,
mattsse and
stevencartavia
as code owners
mattsse
reviewed
May 23, 2026
Member
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
One note on the stored policy semantics: KeyAuthorization distinguishes None as unrestricted from Some([]) as deny-all, but SessionEntry stores limits/scope as defaulted empty vecs. As written, unrestricted authorizations are rejected when the stored policy was omitted. Could we preserve that distinction, e.g. by storing these fields as Option<Vec<_>> or mapping empty stored fields to expected None if empty means unrestricted?
Contributor
Author
|
@mattsse Have cleared up session policy semantic boundaries |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #14827 and #14878 for OSS-162.
#14827 added the initial Tempo session registry scaffold: session metadata, wallet/sessions.toml, atomic upsert/removal, expiry tracking, and shared TOML registry helpers. #14878 made the storage semantics explicit by keeping temporary session key material inside session entries instead of the persistent wallet/keys.toml access-key store.
This PR adds the next resolver layer:
it loads a live session-scoped key from the local session registry, expires stale entries before use, validates that the stored key material matches the recorded session key address, and returns the WalletSigner plus TempoAccessKeyConfig needed to use that session key for outgoing transactions.
It also decodes and validates inline key_authorization data, ensuring the authorization belongs to the stored key, chain, and root signer, and that its expiry, spending limits, and call scope match the stored session policy.