feat: cast send --create
#2871
Merged
feat: cast send --create
#2871
+297
−233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works like a charm! Thank you @gakonst |
rkrasiuk
approved these changes
Aug 22, 2022
| } // Checking if signer isn't the default value | ||
| // 00a329c0648769A73afAc7F9381E08FB43dBEA72. | ||
| } else if config.sender != | ||
| Address::from_str("00a329c0648769A73afAc7F9381E08FB43dBEA72").unwrap() |
There was a problem hiding this comment.
shall we move this to a constant ?
There was a problem hiding this comment.
yeah good idea,
can do this in a followup since this is used in a bunch of places
Co-authored-by: Roman Krasiuk <rokrassyuk@gmail.com>
mattsse
approved these changes
Aug 22, 2022
|
thank you sirs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Previously,
cast sendwould not allow for an optionalto, which would preclude people from deploying raw bytecode. This addresses it in the same way thatcast estimate --createworks. Also refactors thecast sendlogic to a separate file.