Skip to content

Conversation

@grandizzy
Copy link
Collaborator

@grandizzy grandizzy commented Sep 6, 2024

Motivation

Closes #6643

Solution

  • events found are always pushed at the back of queue
  • when new expected events are added make sure they're not interfere with events already found (insert new before first found event)
  • when fill or check, do not account found events: if fill needed then start with entry before first found event then push at the same location. For check action start in order, from the first event in queue

@grandizzy grandizzy changed the title fix(6643): do not account already matched events when fill or check fix(cheatcodes): do not account already matched emit events when fill or check Sep 6, 2024
@grandizzy grandizzy marked this pull request as ready for review September 6, 2024 13:40
@grandizzy
Copy link
Collaborator Author

grandizzy commented Sep 6, 2024

while this works I am going to try a different approach too by putting matched events in a sepparate vector (or not retaining them at all) to make sure they are not mixed with unmatched, converting to draft to see how that looks

@grandizzy grandizzy marked this pull request as draft September 6, 2024 19:10
@grandizzy grandizzy marked this pull request as ready for review September 7, 2024 04:02
@grandizzy grandizzy merged commit 8a51b89 into foundry-rs:master Sep 7, 2024
@grandizzy grandizzy deleted the issue-6643 branch September 7, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Forge test expectEmit fails when it should succeed

2 participants