Jump to conversation
Unresolved conversations (0)
Nice work!

Nice work!

All of your conversations have been resolved.

Resolved conversations (6)
@Fyorl Fyorl Jan 2, 2023
Core augments the `String.prototype` with a `capitalize` method that does this.
Outdated
module/documents/actor/trait.mjs
@Fyorl Fyorl Jan 2, 2023
See comment above about our minimum compatibility. We shouldn't need to index on `data.`.
Outdated
module/documents/actor/trait.mjs
@Fyorl Fyorl Jan 2, 2023
The system's minimum compatibility is `10` so it shouldn't be necessary to check this.
Outdated
module/documents/actor/trait.mjs
arbron
@Fyorl Fyorl Jan 2, 2023
Do we need to check for a type of `checkbox`? Would editing the custom `text` input also fire this?
Outdated
module/applications/actor/trait-selector.mjs
@Fyorl Fyorl Jan 2, 2023
Do we gain much from this being a `DocumentSheet` vs a more generic `FormApplication`?
module/applications/actor/trait-selector.mjs
arbron
@Fyorl Fyorl Jan 2, 2023
Maybe we can move these above the `super` call to prevent unnecessary work.
module/applications/actor/trait-selector.mjs