[#2472] Change ammo logic for attack and damage rolls

[krbz999]

Instead of a damage roll requiring a preceding attack roll to gain the benefit of 'ammo damage', the damage roll simply checks if the item has ammo and can attack. The attack roll simply serves to consume ammo, nothing more.

There are some additional benefits to this.

• If one user made the attack roll, another user can still gain the benefit of the ammo on the damage roll, in that weird edge case of two owners of one actor, where before the addition of _ammo to the item was local only.
• Users can make all their attack rolls first, and then roll all the damage rolls for easier calculation.
• Users can "redo" a damage roll that was meant to be a critical hit, without having to make another attack roll first.

[arbron]

So the issue with this is that ammo's quantity is consumed on attack, which also means that ammo might have 0 uses remaining or the item might be fully deleted by the time damage is rolled (if delete on empty is checked), resulting in no ammo being available to calculate damage bonuses.

[krbz999]

So the issue with this is that ammo's quantity is consumed on attack, which also means that ammo might have 0 uses remaining or the item might be fully deleted by the time damage is rolled (if delete on empty is checked), resulting in no ammo being available to calculate damage bonuses.

Ammo does not get destroyed.