Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign A/V settings to maintain a transient state of connected clients, their muted/hidden status, and their currently speaking status. #3659

Closed
aaclayton opened this issue Sep 25, 2020 · 4 comments
Assignees
Labels
av Issues related to integrated A/V conferencing via RTC

Comments

@aaclayton
Copy link
Contributor

This would allow for a few things:

  1. Display a muted/hidden icon for all users when a user mutes themselves.
  2. Only process audio levels of your own local master stream and simply obtain an "is speaking" indicator from the socket.
@aaclayton
Copy link
Contributor Author

marked this issue as related to #3328

@aaclayton
Copy link
Contributor Author

marked this issue as related to #3570

@aaclayton
Copy link
Contributor Author

Originally in GitLab by @bekit

I like this plan. I'm already bypassing the Foundry "is speaking" logic with the JitsiRTC module and manually setting the indicator using Jitsi's API-based audio level detection. (_onTrackAudioLevelChanged)

I'm in favor of having this be something that is manually triggered by the AVClient so native detection can be used easier.

@aaclayton
Copy link
Contributor Author

Originally in GitLab by @anathemamask

Commented on by @bekit in #5743

Feature Summary

It would be nice to be able to see if a user has their A/V muted or if they have PTT enabled. Currently these settings are only stored in the local client settings store, so they can't be read by other users. This would help to debug why a user isn't able to be heard or seen in an A/V session.

User Experience

Ideally, the settings will be made available under the settings store so something like the following could be called:

if (game.webrtc.client.settings.getUser("someuserid").voiceMode === "activity") {...}

In addition to this, having additional indicators on the user camera view notification-bar element would be helpful for displaying state. Suggested elements:

<i class="fas fa-podcast fa-fw status-remote-ptt hidden" title="${game.i18n.localize("WEBRTC.VoiceModePtt")}"></i>
<i class="fas fa-microphone-alt-slash fa-fw status-remote-muted hidden" title="${game.i18n.localize("WEBRTC.IndicatorMuted")}"></i>
<i class="fas fa-eye-slash fa-fw status-remote-hidden hidden" title="${game.i18n.localize("WEBRTC.IndicatorHidden")}"></i>

The status-remote-ptt indicator could be visible when the user is set to PTT mode and lit green when actively broadcasting.

Priority/Importance

Nice to have. This could be done strictly through modules, and I may do so, but it'd be nice to have it built in to foundry.

@Fyorl Fyorl self-assigned this Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
av Issues related to integrated A/V conferencing via RTC
Projects
No open projects
Status: No status
Development

No branches or pull requests

2 participants