Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Token#_onDelete logic to better clean-up sight and light sources prior to downstream hooks #6896

Closed
aaclayton opened this issue Mar 26, 2022 · 1 comment
Closed

Improve Token#_onDelete logic to better clean-up sight and light sources prior to downstream hooks #6896

aaclayton opened this issue Mar 26, 2022 · 1 comment
Assignees
@aaclayton
Labels
bug Functionality which is not working as intended tokens Issues related to Tokens and their appearance
Milestone
Version 9 - Stabl...

Comments

@aaclayton
Copy link
Contributor

Originally in GitLab by @dev7355608

Environment Details

  • Foundry VTT Version: 9.255

Issue Description

In the deleteToken hook the light and vision source are still in the sources even though they have just been destroyed. Only after the the hooks finish the sources are cleared. Ambient light and sound sources are properly deleted before the delete hooks are executed.
@aaclayton
Copy link
Contributor Author

Hopefully we can change the tear-down order of this.

@aaclayton aaclayton self-assigned this Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaclayton aaclayton

Labels
bug Functionality which is not working as intended tokens Issues related to Tokens and their appearance
Projects
No open projects
Foundry VTT - Version 9
Status: No status
Milestone
Version 9 - Stable Patch 4
Development

No branches or pull requests
1 participant
@aaclayton