Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhead tiles now appear correctly for GM users, according to tile foreground menu status. #7919

Closed
Fyorl opened this issue Aug 25, 2022 · 5 comments
Assignees
Labels
bug Functionality which is not working as intended tiles Issues related to Tiles and their appearance

Comments

@Fyorl
Copy link
Contributor

Fyorl commented Aug 25, 2022

Originally reported by alaustin#0963 https://discord.com/channels/170995199584108546/956306859491471420/1012129693559947415

ALL MODULES DISABLED? TRUE
OS, Hosting, Browser (if applicable): Win10, Electron App
Short Description of bug: Overhead Tiles are always visible as a GM.
Simple steps to reproduce the bug: Place an Overhead Tile. It will always be visible rather than being translucent for GMs as they behave in V9.
Screenshots and/or console errors:

image

@Fyorl Fyorl added bug Functionality which is not working as intended tiles Issues related to Tiles and their appearance labels Aug 25, 2022
@Fyorl Fyorl added this to the Version 10 - Stable milestone Aug 25, 2022
@Feu-Secret Feu-Secret self-assigned this Aug 25, 2022
@aaclayton aaclayton added the nonrepro Bugs which are not yet able to be reproduced. label Aug 25, 2022
@Feu-Secret Feu-Secret removed the nonrepro Bugs which are not yet able to be reproduced. label Aug 25, 2022
@Feu-Secret Feu-Secret changed the title Overhead tiles are always visible as GM Overhead tiles now appear correctly for GM users, according to tile foreground menu status. Aug 25, 2022
@Fyorl
Copy link
Contributor Author

Fyorl commented Sep 16, 2022

Additional user report claiming this issue as regressed:

Originally reported by HarryFurAlle#5062 https://discord.com/channels/170995199584108546/956306859491471420/1019970755322204181

ALL MODULES DISABLED? true
OS, Hosting, Browser (if applicable): Windows, Chrome
Short Description of bug: #7919 The bug in this closed issue has been reintroduced at some point. Overhead tiles are always visible and never semi-transparent for the GM.
Simple steps to reproduce the bug:

  1. Create a new world without modules.
  2. Place a tile and set it to Overhead.
  3. Watch with sadness as the GM.

Screenshots and/or console errors:

image

@Fyorl Fyorl reopened this Sep 16, 2022
@corpocracy
Copy link

I'm having same issues as Fyorl above and can also reproduce. Some additional notes:

  1. If marked as Overhead, not semi-transparent. If marked as Overhead AND Roof, will be semi-transparent.
  2. Tiles marked as Overhead are always selectable and can be interacted with even when the Foreground Layer is not toggled.
  3. The only thing the Foreground Layer toggle seems to do currently is make Roof tiles opaque.
  4. Makes it impossible to work with normal tiles "underneath" an overhead tile which seems to be a regression from v9

@unsoluble
Copy link

unsoluble commented Oct 26, 2022

An elaboration on note 2 above: It's expected behaviour (from v9) that when you're on one of the two layers, the other layer is not interactable. That is, if you've got an Overhead tile on top of a background tile, when you've toggled to the Background layer all clicks should go right through the (transparent, if the other bits here are fixed) foreground tile and interact with the BG tile underneath. This does not currently work in 288.

@unsoluble
Copy link

Note that the changes released for 10.290 did not include a fix for the interactivity issue noted in my comment above.

@aaclayton
Copy link
Contributor

Note that the changes released for 10.290 did not include a fix for the interactivity issue noted in my comment above.

Sorry, that definitely slipped through the cracks. We need to get a separate issue created for it if you don't mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality which is not working as intended tiles Issues related to Tiles and their appearance
Projects
No open projects
Development

No branches or pull requests

5 participants