Refactoring + Issue #56 GitHub default branch #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor JGitHelper to inject dependencies for interacting with git and rendering the template. This allows to test Git and JGitInteractor classes independently. Due to checking default branch to checkout by looking into HEAD symref of the cloned repo, this fixes #56
eed3si9n
requested changes
Feb 14, 2017
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ |
There was a problem hiding this comment.
This removed Apache header should be added back to all new files.
eed3si9n
approved these changes
Feb 15, 2017
|
Strange error. Actually, it occurs even before PR changes. The problem is in TaskKey[Unit]("writeInvalidFile") := {
IO.write(file("src/main/g8/src/test/scala/invalid.scala"), "invalid file")
}and then tries to compile the code. I do not understand, shouldn't it fail by design? This is invalid scala code, it won't compile. UPD: Sorry, the problem was in sbt-header plugin. It is incompatible with Java 1.6. |
sbt-header plugin requires Java 1.7+.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides refactoring to git interaction module to make it more testable
and adds test for git interaction.
Besides that, it fixes #56 because now default branch is taken
from symref in cloned repository.