Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use search api for maven property. #395

Merged
merged 9 commits into from Nov 3, 2018

Conversation

@kounoike
Copy link
Contributor

kounoike commented Sep 3, 2018

Current implementation (using maven-metadata.xml) can't lookup some sbt-plugins such as sbt-gitbucket-plugin. So I tried to solve this problem.

I found REST API in API doc. This API can solve this problem.

Copy link
Member

xuwei-k left a comment

Please fix tests

[info] MavenTest:
[info] Maven
[info] - should resolve the latest version when found *** FAILED ***
[info]   The Either on which right.value was invoked was not defined as a Right. (MavenTest.scala:36)
[info] - should return an error when the latest version is not found
[info] - should resolve the latest stable version when the latest version is not stable *** FAILED ***
[info]   The Either on which right.value was invoked was not defined as a Right. (MavenTest.scala:73)
[info] - should return the latest version if the latest version is stable *** FAILED ***
[info]   The Either on which right.value was invoked was not defined as a Right. (MavenTest.scala:95)
[info] - should return an error if the latest stable version is not found
[info] *** 3 TESTS FAILED ***
[error] Failed: Total 55, Failed 3, Errors 0, Passed 52, Ignored 1
[error] Failed tests:
[error] 	giter8.MavenTest
[error] (lib / Test / test) sbt.TestsFailedException: Tests unsuccessful
@kounoike kounoike force-pushed the kounoike:pr-use-search-api branch from b4fcbb8 to b0c540b Sep 5, 2018
kounoike added 4 commits Sep 6, 2018
@kounoike kounoike force-pushed the kounoike:pr-use-search-api branch from b33e9e4 to 9750e88 Sep 13, 2018
@kounoike

This comment has been minimized.

Copy link
Contributor Author

kounoike commented Sep 13, 2018

@xuwei-k OK I fixed tests and my mistakes.

@xuwei-k xuwei-k dismissed their stale review Sep 29, 2018

_

@xuwei-k xuwei-k requested a review from eed3si9n Sep 29, 2018
Copy link
Member

eed3si9n left a comment

Thanks for the contribution. It looks mostly ok except for the use of http.

library/src/main/scala/giter8/MavenHelper.scala Outdated Show resolved Hide resolved
@xuwei-k xuwei-k merged commit dcc95f4 into foundweekends:master Nov 3, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.