Remove \X characters in character ranges for url regex.
#10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This might not be the right course of action, but removing them gets all tests to pass. If this is wrong, it implies that the tests are not yet comprehensive enough, but then again, regex tests almost can't be. In the original regex set linked to from the documentation (https://gist.github.com/dperini/729294), these characters are unicode characters like `\u00a1`. I haven't been able to find the equivalent in my searches for regex characters in elixir beginning with a `\X`. I'm sure it also makes for poor search queries. Closes fourkio#9
|
This is still a work in progress as I'm trying to add unicode character matching to urls (including tests) in a way that compiles on Elixir 1.4.4/OTP 20 RC2. |
|
Closing this to create a cleaner pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might not be the right course of action, but removing them gets all
tests to pass. If this is wrong, it implies that the tests are not yet
comprehensive enough, but then again, regex tests almost can't be.
In the original regex set linked to from the documentation
(https://gist.github.com/dperini/729294), these characters are unicode
characters like
\u00a1. I haven't been able to find the equivalent inmy searches for regex characters in elixir beginning with a
\X. I'msure it also makes for poor search queries.
Closes #9
If someone knows how I can rewrite this to properly use
\X, please let me know and I will.