Please pull in additional refactors in the outstanding pull request. #10

Closed
gwk opened this Issue Feb 11, 2013 · 1 comment

Comments

Projects
None yet
2 participants
@gwk
Contributor

gwk commented Feb 11, 2013

There is stuff accumulating in my fork that i would like to see upstream; most recently I did a small refactor of adam's isAcceptableValue changes and he asked me to open an issue. It is all very straightforward stuff.

My change set does not fix the missing NSArray urlEncodedString implementation, but it does add one for NSNumber that replaces the old inlined conditional logic.

Thanks! -g

gwk referenced this issue Feb 11, 2013

Added arrays to [NSDictionary urlQueryString]
Added a block that will verify whether a value is an acceptable class, and
extended [NSDictionary urlQueryString] to support arrays.

@ghost ghost assigned adamalix Feb 11, 2013

adamalix added a commit that referenced this issue Feb 21, 2013

Fixed FSN Issue #10
- FSN_categories.h did not have a [NSArray urlEncodedString] impl.
@adamalix

This comment has been minimized.

Show comment Hide comment
@adamalix

adamalix Feb 21, 2013

Contributor

Fixed with this commit

c55651c

Contributor

adamalix commented Feb 21, 2013

Fixed with this commit

c55651c

@adamalix adamalix closed this Feb 21, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment