Added ability to set connection timeout values. #12

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@jim0020

jim0020 commented Feb 14, 2013

Can set a connection timeout value, in seconds (NSTimeInterval), as a default for all FSNConnection instances, and individually.

@mattchukabam

This comment has been minimized.

Show comment Hide comment
@mattchukabam

mattchukabam Feb 20, 2013

That looks good to me. @gwk Good enough to merge?

That looks good to me. @gwk Good enough to merge?

@gwk

This comment has been minimized.

Show comment Hide comment
@gwk

gwk Feb 20, 2013

Contributor

this looks fine to me. style points:

  • method braces are inconsistent with the rest of the project.
  • i would not use double-underscore prefix for a static variable, because i think of those as being reserved for macro temps and compiler internals.
    other than those minor details it looks great. however i have not actually tested/observed the custom timeout behavior.
    thanks jim!
Contributor

gwk commented Feb 20, 2013

this looks fine to me. style points:

  • method braces are inconsistent with the rest of the project.
  • i would not use double-underscore prefix for a static variable, because i think of those as being reserved for macro temps and compiler internals.
    other than those minor details it looks great. however i have not actually tested/observed the custom timeout behavior.
    thanks jim!
@dyorgio

This comment has been minimized.

Show comment Hide comment
@dyorgio

dyorgio Sep 8, 2014

Come on guys :), merge timeout support to HEAD.

dyorgio commented Sep 8, 2014

Come on guys :), merge timeout support to HEAD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment