Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Incorrect empty line before next boundary #7

Merged
merged 1 commit into from

2 participants

@wardbekker

No empty line / seperator after parameter value before the next boundary. http://www.ietf.org/rfc/rfc1867.txt doesn't specify this newline. This is an issue when uploading an object upload to Amazon's S3 API. It seems their HTTP server treats the newline as part of the value, which is correct according to the RFC. Removing the empty line made the object upload work.

@wardbekker wardbekker Update src/FSNConnection.m
No empty line / seperator after parameter value. http://www.ietf.org/rfc/rfc1867.txt doesn't specify this newline, and Amazon S3 doesn't support newlines (it's treated as part of the value)
05dcf07
@itsbonczek

Thanks for the fix!

@itsbonczek itsbonczek merged commit 996c963 into foursquare:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Dec 19, 2012
  1. @wardbekker

    Update src/FSNConnection.m

    wardbekker authored
    No empty line / seperator after parameter value. http://www.ietf.org/rfc/rfc1867.txt doesn't specify this newline, and Amazon S3 doesn't support newlines (it's treated as part of the value)
This page is out of date. Refresh to see the latest.
Showing with 0 additions and 1 deletion.
  1. +0 −1  src/FSNConnection.m
View
1  src/FSNConnection.m
@@ -716,7 +716,6 @@ - (NSData*)makePostBodyWithBoundary:(NSString*)boundary {
[data appendData:sep];
[data appendData:valData];
[data appendData:sep];
- [data appendData:sep];
}
[data appendData:[[NSString stringWithFormat:@"--%@--\r\n\r\n", boundary] UTF8Data]];
Something went wrong with that request. Please try again.