Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added jsWhere, jsWhereOpt #23

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
1 participant
Contributor

ms-tg commented Aug 23, 2011

Hi Jason,

Let me know if this implementation is helpful, or if you want to take an entirely different tack.

We treated the js $where as an optional string at the top-level of the query. Following the mongo syntax, we generate the clause after the top-level AndCondition in MongoHelpers.buildCondition.

Update: Using this approach, vs a generic "raw" clause interface, one can use phantom types to ensure that there is at most a single $where clause, etc. We didn't finish the phantom types yet, but wanted to get this pull request submitted so that you could review asap. [update 2: we did finish the phantom types, with a test that duplicate $where is prevented]

Regards,
-Marc

Contributor

ms-tg commented Aug 23, 2011

Hi Jason, added the phantom type checking stuff to prevent two $where clauses, or use of a $where in a modify query, etc.

Marc Siegel Merge branch 'master' of https://github.com/foursquare/rogue
Conflicts:
	src/main/scala/com/foursquare/rogue/Query.scala
	src/test/scala/com/foursquare/rogue/QueryTest.scala
c333130
Contributor

ms-tg commented Sep 6, 2011

Any interest in merging this?

Contributor

ms-tg commented May 18, 2012

9-months ping

Contributor

ms-tg commented Jun 13, 2013

I think this pull request is stale now -- shall I remove it?

@ms-tg ms-tg closed this Jun 13, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment