Fix slashem to not block on ES requests #15

Merged
merged 7 commits into from Mar 20, 2012

Conversation

Projects
None yet
2 participants
Contributor

holdenk commented Mar 20, 2012

Slashem used to block on ES requests, avoid this behavior. Also fix the version of finagle & twitter's util-core being included to be scala 2.9.1 versus the "generic" version.

Holden Karau added some commits Mar 15, 2012

Holden Karau Create a new Twitter future to contain the result from ES. 23cd3a8
Holden Karau Try and wrap the ES's ActionListener future in a Twitter future 8a8d923
Holden Karau Trying to figure out whats going wrong with my use of futures around ES. 375182a
Holden Karau Works with futures now.
* Turns out that if you include finagle without a scala specific version
  the util-core it pulls in doesn't quite work with FuturePools correctly.
1a44096
Holden Karau Use the correct executor service pool e42b027
Holden Karau Revert the attempt to wrap the ALF in a Twitter Future
This reverts commit 85c787677a228fee94c19b7e57cb873de5129220.
230a5cf
Owner

holdenk replied Mar 20, 2012

Yes

Contributor

adamalix commented Mar 20, 2012

Looks good other than the println and thread.sleep.

@holdenk holdenk added a commit that referenced this pull request Mar 20, 2012

@holdenk holdenk Merge pull request #15 from holdenk/master
Fix slashem to not block on ES requests
f5dab33

@holdenk holdenk merged commit f5dab33 into foursquare:master Mar 20, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment