From 006637ef4e199f4a41a64899c5f760b6ffe60451 Mon Sep 17 00:00:00 2001 From: Miauwkeru Date: Tue, 20 Feb 2024 13:41:01 +0000 Subject: [PATCH] Move lru_cache definitions to __init__ (#17) Using the lru_cache decorators on class methods, the ones that have a reference to `self`, will also cache self. So we move it to the __init__ of the class (DIS-2913) --- dissect/vmfs/vmfs.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dissect/vmfs/vmfs.py b/dissect/vmfs/vmfs.py index 37d683e..4a0ea07 100644 --- a/dissect/vmfs/vmfs.py +++ b/dissect/vmfs/vmfs.py @@ -155,6 +155,8 @@ def __init__(self, volume=None, vh=None, fdc=None, fbb=None, sbc=None, pbc=None, self.fh.seek(fdc_base * self.block_size) self.resources.open(ResourceType.FD, fileobj=BytesIO(self.fh.read(self.block_size))) + self.file_descriptor = lru_cache(4096)(self.file_descriptor) + # Open the root directory self.root = self.file_descriptor(c_vmfs.ROOT_DIR_DESC_ADDR, "/") @@ -250,7 +252,6 @@ def get(self, path, node=None): return node - @lru_cache(maxsize=4096) def file_descriptor(self, address, name=None, filetype=None): if address_type(address) != ResourceType.FD: raise TypeError(f"Invalid block type: {address_fmt(self, address)}")