New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If one address is wrong, payments fail #106

Open
lukepighetti opened this Issue May 9, 2018 · 11 comments

Comments

Projects
None yet
3 participants
@lukepighetti

lukepighetti commented May 9, 2018

[2018-05-09T10:56:20.802Z] [info] [pigeoncoin] [PaymentProcessor] : Payments to miners: {"nTyvJ1txcVrQDF6nPGXdWbfXqTvma9nJbB":"8215000","n6ikQF7QUkg5Nj2po3wrocgVPafFKqZ5nB":"7095000.0677690431011114","PKHU3WP8bJnjK8Scu6Q1r6c5pV5c1o2uic
":"4999.9322309568988886"}
[2018-05-09T10:56:20.802Z] [info] [pigeoncoin] [PaymentProcessor] : Ok, going to pay from "undefined" address with final amounts: {"nTyvJ1txcVrQDF6nPGXdWbfXqTvma9nJbB":8215000,"n6ikQF7QUkg5Nj2po3wrocgVPafFKqZ5nB":7095000.06776904,"PKHU
3WP8bJnjK8Scu6Q1r6c5pV5c1o2uic":4999.93223095}
[2018-05-09T10:56:20.984Z] [warn] [pigeoncoin] [CoinDaemon] : Daemon returned unexpected return code 500, data = "{\"result\":null,\"error\":{\"code\":-5,\"message\":\"Invalid Pigeon address: PKHU3WP8bJnjK8Scu6Q1r6c5pV5c1o2uic\"},\"id\
":1525863380809}\n"
@lukepighetti

This comment has been minimized.

lukepighetti commented May 9, 2018

In this example we switched NOMP over to testnet to verify payments were working.

We have shares from one mainnet address, and two testnet addresses.

NOMP appears to batch the transaction, submit to daemon, who then kicks back an error.

NOMP continues to try submitting this payment without success.

We have not yet decided if we are going to start with NOMP to create our Terahash Pool. If we do, we'd be offering maintenance on NOMP. Contact from the dev team would make this a lot easier. You can find us on our Discord server. https://pgn.gg/discord

@devnull-ed

This comment has been minimized.

Collaborator

devnull-ed commented May 11, 2018

Make sure you have validation on workers addresses in the config

@leshacat

This comment has been minimized.

leshacat commented Oct 24, 2018

@lukepighetti to contribute you just press the "fork" button... Then you code a bit... Then you press the "pull request" button :)

Fork a fork... Fork my fork :P

@lukepighetti

This comment has been minimized.

lukepighetti commented Oct 24, 2018

I have had a PR open on foxer's NOMP for five months with no movement. But I appreciate the sentiment. @leshacat foxer666/node-multi-hashing#11

@leshacat

This comment has been minimized.

leshacat commented Oct 24, 2018

@lukepighetti why do you care if he accepts the PR ? People will download or fork your fork... And you can fork a fork of NOMP so that way there is an active developer... Like (again) my fork or 1301313Y fork (BootNOMP) - Also some fork owners search other forks for features and things to pull from them :)

That is how GH and OpenSource works :) Shit gets merged up, down, left, and right :)

I submitted one and he accepted it, another one just sat there... I'm not sure foxer666 is looking for them, or there are too many and he has too little time (I see him respond to serious ones)

Start working on fork of 1301313Y/BootNOMP or leshacat/BootNOMP we seem to answer and are looking for help to rebirth NOMP :)

@leshacat

This comment has been minimized.

leshacat commented Oct 24, 2018

OH this issue btw, I can fix when I work on the payment processor. I am planning to un-batch the transactions, or batch them manually.

I however have many things on my plate to deal with before that.

clone my fork here leshacat/BootNOMP

@leshacat

This comment has been minimized.

leshacat commented Oct 24, 2018

Issue is cause of same problem "batch processing" here #145

@lukepighetti

This comment has been minimized.

lukepighetti commented Oct 24, 2018

Hi Lesha, glad to see you are taking it upon yourself to maintain NOMP on your own. I wish you the best of luck, it is a promising mining pool.

@leshacat

This comment has been minimized.

leshacat commented Oct 25, 2018

@lukepighetti I am not doing it on my own, the OpenSource community is helping... If you ask me, my opinion is that I am taking the easy work... But its the stuff you put off because it is boring or monotonous.

I been working mostly on some minor UI improvements, Docs, Docker, and config options (donation addresses, etc.) as well as applying patches I find elsewhere for other forks of NOMP/BootNOMP that have not made merges up the ladder. Work on core parts like stratum and cryptography must be left to the experts.

1301313Y is somewhat active as well, and has at least been accepting PR's from me. Not sure if he is doing any coding himself. Thanks for compliment though.

I am going to make a branch and start working on this issue specifically because it is a rather serious issue. Watch this ticket and my repo leshacat/BootNOMP/tree/payment-processor-patch-1 for a fix :)

I chose BootNOMP because it was forked off the new NOMP and had the UI completely redone :) It had minimal work to get her back up to working status :)


[EDIT] @lukepighetti - how many users is it trying to pay out? I read that the issue occurs when it tries to pay out 15-25 users at the same time... Just curious. I will make it manually batch transactions with a config option to change the number in the batch defaulted to 10 to be safe...

Jusy FYI those payments are not lost, just stuck until the code is fixed and new payment processor is run... If you can manually sort it out, do it, otherwise tell your miners this is a NOMP issue that is being resolved and reference them this ticket.

LeshaCat is on the prowl for work and pounced on an issue 🐈 give me a couple hours, a day or two at most...

@leshacat

This comment has been minimized.

leshacat commented Oct 25, 2018

Personal Note: This issue is related to batch processing of payments exceeding 10-15 per RPC call. Fix is to manually batch payments.

@leshacat

This comment has been minimized.

leshacat commented Oct 27, 2018

@lukepighetti @everyone:

I may have fixed the batch transactions, by adding a pool_config option maxBatchTransactions which I would advise setting to 10 for every coin (who knows how many forks are affected, considering this affects bitcoin

To test it out, clone EasyNOMP then run:
git checkout paymentprocessor-patch-1
git pull
npm install
npm audit fix

Edit your pool_configs/*.json to add the new value maxBatchTransactions: 10, under the payment processor section.

WARNING: This code affects payments and is currently untested!

I will be able to test this shortly on my pool because my brother miners left me :-/

If you have tested this please post as much of your log as possible, and let me know if it works so I can merge it to master, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment